Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add activity watchface #10

Closed
wants to merge 4 commits into from
Closed

Add activity watchface #10

wants to merge 4 commits into from

Conversation

aebruno
Copy link

@aebruno aebruno commented Feb 19, 2017

The idea for this watchface is to display the value of step counter
against a daily goal using the pedometer sensor in bass. Until sensors
are fully supported in AsteroidOS we display the current battery charge
level as a proof of concept.

@aebruno
Add activity watchface
ccde16f 
The idea for this watchface is to display the value of step counter
against a daily goal using the pedometer sensor in bass. Until sensors
are fully supported in AsteroidOS we display the current battery charge
level as a proof of concept.
@FlorentRevest
Copy link
Member

Hi,
First of all this is a good idea. However I won't merge it for several reasons:

  • there is already a circular progress component in qml-asteroid, you should use/improve it instead of recreating your own https://git.io/vD5Lt
  • without shadows your text is impossible to read on white backgrounds.
  • this doesn't support sensors yet. (which would be more useful)
  • you should consider working with a project's designer on how to choose a color different than red or this kind of thing. I can put you in touch with one of them to discuss the idea.
    Anyway, good job, i can't wait to see a final version of that merged !

@aebruno
Copy link
Author

aebruno commented Feb 19, 2017

All sounds good! Thanks for the great feedback. I'll try and get some of these improvements implemented.

@aebruno
Use ProgressCircle from asteroid controls
a78ef75 
- Use the circular progress component in qml-asteroid
- Add drop shadow for better reading on white backgrounds
@aebruno
ProgressCircle value should be from 0 to 1.
f8a9965
@aebruno
Update screenshot
5bb0aa1
@FlorentRevest
Copy link
Member

Hi aebruno. I like the new watchface much more good job! Please refer to the second paragraph of this post #11 (comment) which is also completely relevant to your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aebruno @FlorentRevest