pymol: init at 1.8.4 #23007
pymol: init at 1.8.4 #23007
Conversation
|
Any idea on why have it failed? Maybe relevant: openai/gym#164 |
| let | ||
| version = "1.8.4.0"; | ||
| in | ||
| stdenv.mkDerivation { |
There was a problem hiding this comment.
There is also buildPythonApplication in pythonPackages which should automate all the phases you have overriden. Have you tried that?
|
|
||
| meta = { | ||
| description = "Molecule editor and visualizer"; | ||
| }; |
There was a problem hiding this comment.
Please include more information in the meta section. At least the license and the homepage should be present.
|
@fpletz Applied buildPhytonApplication, and added license, a bit more detailed description as well as the website. Although I still doubt that it will build on Mac. Note: This version of PyMol does not utilises Python megawidgets, as I could not find this package on nixpkgs. It doesn't cause any problem:
|
| sha256 = "0yfj8g5yic9zz6f0bw2n8h6ifvgsn8qvhq84alixsi28wzppn55n"; | ||
| }; | ||
|
|
||
| buildInputs = [ python27Packages.numpy glew freeglut libpng libxml2.dev tk freetype ]; |
There was a problem hiding this comment.
Adding libxml2 to buildInputs should automatically pull libxml2.dev as well.
| let | ||
| version = "1.8.4.0"; | ||
| in | ||
| python27Packages.buildPythonPackage { |
There was a problem hiding this comment.
python27Packages.buildPythonApplication is probably wanted here.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)