-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
pymol: init at 1.8.4 #23007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pymol: init at 1.8.4 #23007
Conversation
Any idea on why have it failed? Maybe relevant: openai/gym#164 |
let | ||
version = "1.8.4.0"; | ||
in | ||
stdenv.mkDerivation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also buildPythonApplication
in pythonPackages
which should automate all the phases you have overriden. Have you tried that?
|
||
meta = { | ||
description = "Molecule editor and visualizer"; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include more information in the meta section. At least the license and the homepage should be present.
@fpletz Applied buildPhytonApplication, and added license, a bit more detailed description as well as the website. Although I still doubt that it will build on Mac. Note: This version of PyMol does not utilises Python megawidgets, as I could not find this package on nixpkgs. It doesn't cause any problem:
|
sha256 = "0yfj8g5yic9zz6f0bw2n8h6ifvgsn8qvhq84alixsi28wzppn55n"; | ||
}; | ||
|
||
buildInputs = [ python27Packages.numpy glew freeglut libpng libxml2.dev tk freetype ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding libxml2
to buildInputs
should automatically pull libxml2.dev
as well.
let | ||
version = "1.8.4.0"; | ||
in | ||
python27Packages.buildPythonPackage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python27Packages.buildPythonApplication
is probably wanted here.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)