Provide copyright field in RSS feed #2676
Conversation
nikola/nikola.py
Outdated
| @@ -1660,6 +1660,11 @@ def generic_rss_renderer(self, lang, title, link, description, timeline, output_ | |||
| language=lang | |||
| ) | |||
|
|
|||
| copyright = self.config['CONTENT_FOOTER'](lang) | |||
There was a problem hiding this comment.
The existence of copyright should be configurable, and CONTENT_FOOTER might not be the right place to take it from.
|
First, thank you for reviewing this pull request! I'm happy to address the requested changes. I'll change Do you have a recommendation or a better general-purpose place to take that from? |
|
I’m afraid there isn’t anything immediately suitable. You could always create a new config variable — say, |
anderbubble
changed the title
Taking in recommendations from getnikola#2676 * Added RSS_COPYRIGHT and RSS_COPYRIGHT_PLAIN * Added RSS_COPYRIGHT_FORMATS (like CONTENT_FOOTER_FORMATS)
|
@Kwpolska I think I've addressed your concerns. Let me know how this looks now. (I'm happy to squash the commits, too, if that's useful.) edit: It appears that codacy doesn't follow how config variables become translatable? Or did I do something wrong? (It appears to work in my environment.) |
nikola/conf.py.in
Outdated
| @@ -1240,3 +1240,9 @@ GLOBAL_CONTEXT = {} | |||
| # GLOBAL_CONTEXT as parameter when the template is about to be | |||
| # rendered | |||
| GLOBAL_CONTEXT_FILLER = [] | |||
|
|
|||
| # A simple copyright tag for inclusion in RSS feeds that works just | |||
nikola/nikola.py
Outdated
| @@ -1660,6 +1675,11 @@ def generic_rss_renderer(self, lang, title, link, description, timeline, output_ | |||
| language=lang | |||
| ) | |||
|
|
|||
| if copyright_ is True: | |||
There was a problem hiding this comment.
Just do if copyright_: here. Add a comment for future readers that the second if is checking if any copyright info is set.
|
The test for equivalency to True is intentionally functional: it allows you
to override the configured copyright by providing one explicitly as an
argument.
edit: With the benefit of sleep, an `if copyright_ is None` idiom is probably clearer here. Did that in stead.
|
I was using True before to decide whether RSS_COPYRIGHT* should be read from config; but None is probably more idiomatic, and still supports specifying an explicit value as an argument.
|
@Kwpolska I can rebase on top of current master if you'd like, to resolve the conflict; should I squash as well, or leave as-is? |
anderbubble
changed the title
|
No need to squash. |
|
Merged. Thanks for contributing to Nikola! 🎉 |
I'm working on enhancing Nikola to support publishing a podcast RSS feed. Most of this work is going into a "postcast" plugin I'm working on, and will submit or publish eventually; but some of what I'm trying to do requires support in Nikola itself.
This PR aims to support providing a copyright field in RSS feeds as recommended by iTunes connect.
Other related PRs I'm working on:
I'd also be interested in direction for where and how to publish a plugin, when that's ready.