buildRustPackage: fix deprecated use of registry.index config key #22987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See rust-lang/cargo@8214bb9 for the cargo commit which deprecated the registry.index key, and implements this as a replacement. This gets rid of the error message warning: custom registry support via the `registry.index` configuration is being removed, this functionality will not work in the future
|
@anderspapitto, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wizeman, @madjar and @abbradar to be potential reviewers. |
|
Awesome, thank you! |
|
Hi @anderspapitto, it looks like this change has broken building some packages. Can you help? #23282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
rust-lang/cargo@8214bb9
for the cargo commit which deprecated the registry.index key, and
implements this as a replacement. This gets rid of the error message
warning: custom registry support via the
registry.indexconfiguration is being removed, this functionality will not work in the futureI tested by faking a depsSha256 for a package using buildRustPackage, rebuilding, and verifying that