Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis: 3.2.7 -> 3.2.8 #22992

Merged
merged 1 commit into from
Feb 19, 2017
Merged

redis: 3.2.7 -> 3.2.8 #22992

merged 1 commit into from
Feb 19, 2017

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Feb 19, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @grahamc, @peti and @nathan7 to be potential reviewers.

@grahamc grahamc merged commit ee75eff into NixOS:master Feb 19, 2017
@grahamc
Copy link
Member

grahamc commented Feb 19, 2017

Thank you :)

@LnL7 LnL7 deleted the redis-3.2.8 branch February 19, 2017 13:45
@LnL7
Copy link
Member Author

LnL7 commented Feb 19, 2017

I almost forgot about it.

@grahamc
Copy link
Member

grahamc commented Feb 19, 2017

Me too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @mention-bot @grahamc