-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rational() and IO.try_convert do not work for BasicObjects #4484
Comments
I would guess our ported logic for type these type conversions just needs some updating.
I think @juliancheal is going to take a poke at this. |
Oops, I had the wrong bug for @juliancheal...we asked him to look at #4483. However the two bugs are rather similar. |
... also added a caching respond_to? call-site (see jruby#4484)
... also added a caching respond_to? call-site (see #4484)
... adding an |
Environment
jruby 9.1.8.0-SNAPSHOT (2.3.1) 2017-02-06 3f97c7a Java HotSpot(TM) 64-Bit Server VM 25.111-b14 on 1.8.0_111-b14 +indy +jit [linux-x86_64]
Linux ok 4.4.0-59-generic #80-Ubuntu SMP Fri Jan 6 17:47:47 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Test Case
Expected Behavior
nil
for the try_convert case, and raises a TypeError forRational()
. If conversion would be possible (to_io
orto_r
exist), it would properly convertActual Behavior
to_io
orto_r
exist):The text was updated successfully, but these errors were encountered: