Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sile: Init at 0.9.4 #22525

Merged
merged 1 commit into from
Feb 11, 2017
Merged

Sile: Init at 0.9.4 #22525

merged 1 commit into from
Feb 11, 2017

Conversation

lprndn
Copy link
Contributor

@lprndn lprndn commented Feb 7, 2017

Motivation for this change

SILE is a nice tool for generating PDFs with layout and typesetting. Simpler than Tex and written in Lua.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor

vbgl commented Feb 7, 2017

Here is a patch to make it build on darwin: sile.patch

Usually, we prefer released version. What’s wrong with 0.9.4?

IIRC, fetchgit enables you to automatically fetch submodules, without the need to explicitly mention URL, revision and hash.

@rycee
Copy link
Member

rycee commented Feb 7, 2017

If you using packaging an unreleased version then the name should be "sile-unstable-2017-01-25", see the package naming section of the Nixpkgs manual.

Also, having hash as version will not work. Firstly, it is possible that the hash will start with a letter and then the version extraction will not work. I.e., a hypothetical name "sile-ac3884" will result in Nix thinking the name is "sile-ac3884" and that there is no version part. Secondly, Nix will not be able to determine whether one version is greater than another, a later release may have a hash starting with a lower digit than the previous release; this would cause nix-env -u to not work as expected.

Edit: And I agree with @vbgl, unless there is a strong reason otherwise we should package released versions.

@lprndn lprndn changed the title Sile: Init at 56c652 Sile: Init at 0.9.4 Feb 7, 2017
@lprndn
Copy link
Contributor Author

lprndn commented Feb 7, 2017

Applied @vbgl patch for darwin compatibility.
I also switched back to current release 0.9.4. I therefore used fetchurl instead of fetchgit as it seemed easier and (guessing here) faster.
bootstrap.sh is not needed anymore. I don't know if it changes anything for darwin build.

Thanks @vbgl and @rycee for your advices and explanations.

@vbgl
Copy link
Contributor

vbgl commented Feb 7, 2017

Since you now use a released version, you probably no longer need the autotools as inputs.

@lprndn
Copy link
Contributor Author

lprndn commented Feb 7, 2017

Successfully tested without autoconf, automake, libtool.

@rycee
Copy link
Member

rycee commented Feb 11, 2017

@lprndn Looking fine and builds ok for me. Please squash these commits into a single one, though. It should have the message "sile: init at 0.9.4".

@lprndn
Copy link
Contributor Author

lprndn commented Feb 11, 2017

@rycee Done!

@vbgl vbgl merged commit e2834ca into NixOS:master Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants