[WIP] release-cross: Try cross compiling from darwin too #22526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @rbvermaa and @aszlig to be potential reviewers. |
Most of the from-darwin builds will probably fail, but I'd like to know how.
Ericson2314
force-pushed
the
release-cross-darwin
branch
from
eaa463a
to
23e7fa7
Compare
Ericson2314
changed the title
…gh bootstrapping Merge commit '5ad696b06763b7c5c6e1aa7ed848a50bff78c8d5' into release-cross-darwin
copumpkin
reviewed
Mar 15, 2017
| @@ -6078,7 +6078,7 @@ with pkgs; | |||
|
|
|||
| binutilsCross = assert targetPlatform != buildPlatform; lowPrio ( | |||
| if targetPlatform.libc == "libSystem" then darwin.cctools_cross | |||
| else forcedNativePackages.binutils.override { | |||
| else forcedNativePackages.binutils-raw.override { | |||
There was a problem hiding this comment.
Why? binutils-raw is very rarely what you want, as the GNU tools in it often screw up Mach-O binaries.
There was a problem hiding this comment.
Both are wrong; I fix in my ghc-android branch: you need to feed in the overridden binutils into the darwin wrapper.
|
I'll open a new one or reopen this once I deal with all my outstanding commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Most of the from-darwin builds will probably fail, but I'd like to know how. I'm going through my past cross PRs looking for regressions. This PR will fix them each time, for an "alternative" fixed history
Things done
Looking at hashes so when its ready already-building packages should stay the same.