Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

googleearth: 6.0.3.2197 -> 7.1.4.1529 #22377

Merged
merged 1 commit into from
Feb 3, 2017
Merged

Conversation

Lassulus
Copy link
Member

@Lassulus Lassulus commented Feb 2, 2017

Motivation for this change

this is #18115 with correct hashes
this fixes #17956

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Lassulus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @gridaphobe and @jwiegley to be potential reviewers.

@HappyEnt
Copy link
Contributor

HappyEnt commented Feb 2, 2017

There is a function for checking the system architecture already included in stdenv.
stdenv.isx86_64 and stdenv.isi686 or maybe even stdenv.is64bit.

@joachifm joachifm merged commit 1e835f2 into NixOS:master Feb 3, 2017
@joachifm
Copy link
Contributor

joachifm commented Feb 3, 2017

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

googleearth missing fontconfig
4 participants