haddock-api: fix build on GHC-8.0.2 #22369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@basvandijk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @abbradar and @pikajude to be potential reviewers. |
|
This should also be cherry picked on |
|
Is it possible to download that patch from somewhere rather than checking it into our repository? |
|
I do have a git commit here basvandijk/haddock@f4c5e46. Is there a nix function that turns a commit into a patch? If so, we still have to patch the cabal file but we can also just jailbreak it. |
|
I see there's a |
basvandijk
force-pushed
the
haddock-api-ghc802-fix
branch
from
eb251b8
to
344227b
Compare
|
@peti I forced pushed a new commit with your recommendation. |
|
Thank you very much! |
peti
added a commit
that referenced
this pull request
Feb 2, 2017
haddock-api: fix build on GHC-8.0.2 (cherry picked from commit 072ebac)
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
haddock-api: fix build on GHC-8.0.2 (cherry picked from commit 072ebac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peti I discovered that
ghcjsHEADdoesn't build (my bad) because its dependencyhaddock-apidoesn't build on GHC-8.0.2. This patch should fix that.There's another problem with the
shellylibrary which I'm investigating right now.