Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libretro: add mGBA core #22618

Closed
wants to merge 2 commits into from
Closed

Conversation

hrdinka
Copy link
Contributor

@hrdinka hrdinka commented Feb 10, 2017

Motivation for this change

This adds the mGBA retroarch port as a core to libretro.

CC @edwtjo, @MP2E

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@hrdinka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @dezgeg and @MP2E to be potential reviewers.

@joachifm
Copy link
Contributor

I fixed the merge conflict via the github web interface mainly to test it out, feel free to overwrite with a force push, if you prefer :)

@hrdinka hrdinka closed this in a7ca114 Feb 12, 2017
@hrdinka
Copy link
Contributor Author

hrdinka commented Feb 12, 2017

Oh, thats an awesome new feature :) I have cherry-picked & rebased all changes directly onto master to keep the history clean.

@hrdinka hrdinka deleted the add/libretro-mgba branch February 12, 2017 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants