Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minecraft: update launcher - WIP #22617

Closed
wants to merge 1 commit into from
Closed

Conversation

cpages
Copy link
Contributor

@cpages cpages commented Feb 10, 2017

The minecraft launcher is about to be updated, as advertised here.

I cannot fully test this since I'm getting an 'Illegal instruction' error (time to get a new machine I guess :)

The icon is missing again for now, since we don't have the jar.

@mention-bot
Copy link

@cpages, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ryantm, @nathan7 and @edolstra to be potential reviewers.

@ryantm
Copy link
Member

ryantm commented Feb 10, 2017

Cool. I'll try to take a look at this this weekend. Let's get the icon working before merging this!

@ryantm
Copy link
Member

ryantm commented Feb 11, 2017

I also get the "Illegal Instruction" error. Also, they've updated Minecraft_staging.tar.gz in-place and the new has is currently: 06yx7rcq4yl5ds2ccav8rqg6kv6dfy4zbgifzvgpf8cqn1rk3a0a

Error:

ryantm@laptop1 ~/p/nixpkgs (minecraft)$ minecraft
/nix/store/42yhvsr19z9rx3cgflja25gyjzk6syf6-minecraft-2.0.759/share/minecraft/.launcher-wrapped: unrecognized option '--type=zygote'
/nix/store/42yhvsr19z9rx3cgflja25gyjzk6syf6-minecraft-2.0.759/share/minecraft/.launcher-wrapped: unrecognized option '--no-sandbox'
/nix/store/42yhvsr19z9rx3cgflja25gyjzk6syf6-minecraft-2.0.759/share/minecraft/.launcher-wrapped: unrecognized option '--lang=en-US'
Illegal instruction
ryantm@laptop1 ~/p/nixpkgs (minecraft)$ /proc/self/exe: unrecognized option '--type=gpu-process'
/proc/self/exe: unrecognized option '--no-sandbox'
/proc/self/exe: unrecognized option '--window-depth=24'

@ryantm
Copy link
Member

ryantm commented Feb 11, 2017

Here is the AUR package for inspiration: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=minecraft-launcher

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 24, 2018

(triage) Is this still being looked after?

@c0bw3b c0bw3b self-assigned this Oct 24, 2018
@cpages
Copy link
Contributor Author

cpages commented Oct 25, 2018

The current installer still works, so let's just close it and I'll try to retake this if needed

@cpages cpages closed this Oct 25, 2018
@nathantalewis
Copy link
Contributor

@cpages, I tried these changes with the latest version of the new launcher (with a few tweaks since there is no .sh file anymore) and I think I'm getting the same illegal instruction error.

The workaround of using the old launcher doesn't work with forge to get mods. Any chance you could open this PR again so we can start using the new launcher?

@cpages
Copy link
Contributor Author

cpages commented Apr 22, 2019

@nathantalewis it's been a while that I don't even play it, so it's low on my priority list, but I'll reopen in case I manage some progress

@nathantalewis
Copy link
Contributor

@cpages, I was able to find a workaround that allowed me to use the old launcher with forge. It turns out there was an empty string in a url field of the forge version json file. I just added the correct url for the version I was using at everything was happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants