zathura: 0.3.6 -> 0.3.7 #22832
Merged
zathura: 0.3.6 -> 0.3.7 #22832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c6f434c
requested changes
Feb 15, 2017
|
|
||
| postInstall = '' | ||
| wrapProgram "$out/bin/zathura" \ | ||
| --prefix PATH ":" "${lib.makeBinPath [ file ]}" \ | ||
| --prefix PATH ":" "${file}/bin" \ |
There was a problem hiding this comment.
makeBinPath will also handle a separate bin output, if it happens to appear; why change this line?
There was a problem hiding this comment.
Seems superfluous to me with just one package. Do you want me to revert it?
There was a problem hiding this comment.
Well, a slow migration to makeBinPath will reduce pain even in the single-package case when for whatever reason file gets multiple outputs (which makes some sense).
So yes, I would be OK with not adding makeBinPath initially, but if it is there, I want it to stay.
There was a problem hiding this comment.
Ok, it makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This release finally fixes the CSS theme errors.
Things done
Note: This needs #22831 merged first.