Skip to content

python2.7-future: #22590 remove platform restriction #22837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Dridus
Copy link
Contributor

@Dridus Dridus commented Feb 15, 2017

Motivation for this change

per #22590, haskellPackages.servant and by extension any package which transitively depends on pythonX.Y-future will fail to build on darwin even though there's apparently no reason why it can't be built there.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" did this though the Oger package failed to build I don't think it was related
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
NeQuissimus Tim Steinbach
@mention-bot
Copy link

@Dridus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@Profpatsch
Copy link
Member

Thanks!

@Profpatsch Profpatsch merged commit aba35a5 into NixOS:master Feb 15, 2017
@Dridus Dridus deleted the remove-python-future-package-restriction branch February 15, 2017 17:25
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants