Skip to content

Commit

Permalink
graphviz_2_0: hide inside monotoneViz
Browse files Browse the repository at this point in the history
The old Graphviz version is vulnerable, but monotone-viz will never feed
it bad input.

(cherry picked from commit c731738)
  • Loading branch information
7c6f434c committed Feb 15, 2017
1 parent 4838518 commit 50b671b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
10 changes: 9 additions & 1 deletion pkgs/applications/version-management/monotone-viz/default.nix
@@ -1,4 +1,12 @@
{stdenv, fetchurl, ocaml, lablgtk, libgnomecanvas, camlp4, glib, pkgconfig, graphviz_2_0, makeWrapper}:
{stdenv, fetchurl, ocaml, lablgtk, libgnomecanvas, camlp4, glib, pkgconfig, makeWrapper
, libtool, libpng, yacc, expat, fontconfig, gd, pango, libjpeg, libwebp, xlibsWrapper, libXaw
}:
# We need an old version of Graphviz for format compatibility reasons.
# This version is vulnerable, but monotone-viz will never feed it bad input.
let graphviz_2_0 = import ./graphviz-2.0.nix {
inherit stdenv fetchurl pkgconfig xlibsWrapper libpng libjpeg expat libXaw
yacc libtool fontconfig pango gd libwebp;
}; in
stdenv.mkDerivation rec {
version = "1.0.2";
name = "monotone-viz-${version}";
Expand Down
File renamed without changes.
6 changes: 0 additions & 6 deletions pkgs/top-level/all-packages.nix
Expand Up @@ -1869,12 +1869,6 @@ in
libdevil = libdevil-nox;
};

/* Readded by Michael Raskin. There are programs in the wild
* that do want 2.0 but not 2.22. Please give a day's notice for
* objections before removal. The feature is integer coordinates
*/
graphviz_2_0 = callPackage ../tools/graphics/graphviz/2.0.nix { };

/* Readded by Michael Raskin. There are programs in the wild
* that do want 2.32 but not 2.0 or 2.36. Please give a day's notice for
* objections before removal. The feature is libgraph.
Expand Down

0 comments on commit 50b671b

Please sign in to comment.