Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ripper on 9.0.x.x reports wrong line number #3386

Closed
yujinakayama opened this issue Oct 11, 2015 · 1 comment
Closed

Ripper on 9.0.x.x reports wrong line number #3386

yujinakayama opened this issue Oct 11, 2015 · 1 comment
Milestone
JRuby 9.1.0.0

Comments

@yujinakayama
Copy link

Ripper on 9.0.x.x wrongly reports line number 2 for sexp or token at line 1.

[1] pry(main)> JRUBY_VERSION
=> "9.0.1.0"
[2] pry(main)> require 'ripper'
=> true
[3] pry(main)> Ripper.sexp('foo')
=> [:program, [[:vcall, [:@ident, "foo", [2, 0]]]]]
[4] pry(main)> Ripper.lex('foo')
=> [[[2, 0], :on_ident, "foo"]]

FYI Ripper on 1.7.22 correctly reports it as line 1.
@yujinakayama yujinakayama mentioned this issue Oct 11, 2015
Merged
@enebo enebo added this to the JRuby 9.0.5.0 milestone Oct 23, 2015
@enebo enebo modified the milestones: JRuby 9.1.0.0, JRuby 9.0.5.0 Jan 21, 2016
@enebo
Copy link
Member

enebo commented Mar 1, 2016

This was fixed in a series of updates on the ruby-2.3 branch (which has since been merged to master).

@enebo enebo closed this as completed Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.1.0.0
Development

No branches or pull requests
2 participants
@enebo @yujinakayama