Don't use gcov symbols if coverage is disabled. #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the unit tests have bit-rotten: the failures don't seem to have anything to do with the changes in my pull request. |
|
I concur that the test failures don't appear to be related to your change. I'm not going to have any time this week to look into them, should we merge you change now - or wait until they have been fixed? |
|
It's your project, so it's up to you. I might see if I can get the test suite passing in another pull request when I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a patch for https://github.com/timvideos/gst-switch/issues/217 (build fails with coverage disabled)