Wow, good find.

👓 @madbook

good catch! one small request, would you mind applying the same fix to https://github.com/reddit/reddit/blob/master/r2/r2/controllers/api.py#L3242-L3243, since it looks like it would suffer from the same issue?

long term I think I can nuke most of the replace_things code altogether - it's more complicated than it needs to be and apparently produces fun bugs like this! Until I can find time to do that though, scoping the response to the main .content div seams reasonable.

💅

@madbook do you mean the POST_hide endpoint? Just to be sure.

@madbook I think I figured out what you meant? It was hard to tell, as the url you gave was broken, but after testing I found the issue existed on distinguishing as well. 💇

Ah, yeah, that's what I meant. I'm guessing what happened is that some other commit was pushed up to master after I posted that link, which moved the line highlighting. Thanks for getting that too, I'll let you know when I get this merged in. 🐟 Thanks!

:P No problem!

cb12896 and 86ef81d

Thank you!

P.S. You've already got one open sourcerer trophy so I probably shouldn't add more each time. Maybe I could just change the text to "A bunch of stuff!" or something?

@umbrae Yeah; adding things would probably make my trophy case look ugly. If you want to change the text to that and the url link to this to clarify on what a "bunch of stuff" is, go for it :P