New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wayland-protocols: 1.11 -> 1.13 #35324
Conversation
Please target staging for this PR because it is a mass rebuild. |
652f6a8
to
8f78969
Compare
Managed to push before changing the base in github (which triggered review, sorry about that). Edit: ofborg added a bunch of wrong labels too :( |
@grahamc: maybe the labels (except rebuild) would better not be touched until Borg is smarter. |
@GrahamcOfBorg eval I think the problem here is changing the base doesn't trigger a re-eval, and I think this eval ^ will fix all the wrong labels. Do you have additional cases of the labels being definitely wrong, other than the labels not being fixed when the base is changed? |
@vcunat ^ if the changed base triggers a re-eval, will that be sufficiently smart? If not, I'd rather err on the side of no features than annoying features. |
@grahamc: even if it were against master, I still can't see why the non-rebuild labels were added. |
To clarify the steps I took: I moved my branch to staging, cherry picked the wayland-protocol commit and force pushed before changing the base in github. That obviously resulted in a bunch of commits not yet merged in master to show up. Among them I assume there were commits that had new packages, python and cleanup etc. |
Ah, right. I thought you just retargeted the PR without any commit changes. |
Given what has happened and that re-targeting branches now triggers evals, would you like the topic-tagging to be dropped? |
@grahamc: no, hopefully it will be OK now, we'll see. |
Motivation for this change
1.12
includes the stableXDG Shell Protocol
.1.13
is more minor.Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)