Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgudev: add gobjectIntrospection to nativeBuildInputs #35335

Merged
merged 1 commit into from May 23, 2018
Merged

libgudev: add gobjectIntrospection to nativeBuildInputs #35335

merged 1 commit into from May 23, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

This enables the generation of /lib/girepository-1.0/GUdev-1.0.typelib and /share/gir-1.0/GUdev-1.0.gir.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 22, 2018
jtojnar
jtojnar approved these changes Feb 23, 2018
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 64+8 extra KiB so we probably do not need to move it to a separate output.

@jtojnar jtojnar changed the base branch from master to staging February 23, 2018 02:18
@jtojnar jtojnar changed the base branch from staging to master February 23, 2018 02:19
@jtojnar
Copy link
Contributor

jtojnar commented Feb 23, 2018

Should probably go to staging, though.

@jfrankenau jfrankenau mentioned this pull request Feb 24, 2018
Merged
8 tasks
@jfrankenau jfrankenau mentioned this pull request Mar 9, 2018
Merged
8 tasks
@jtojnar jtojnar changed the base branch from master to staging March 28, 2018 10:07
@GrahamcOfBorg GrahamcOfBorg added 2.status: merge conflict and removed 6.topic: GNOME GNOME desktop environment and its underlying platform labels Mar 28, 2018
@jtojnar jtojnar force-pushed the libgudev-gobjectIntrospection branch from 71b335f to b820386 Compare May 23, 2018 17:44
@jtojnar jtojnar force-pushed the libgudev-gobjectIntrospection branch from b820386 to b6b8cdd Compare May 23, 2018 17:46
@jtojnar jtojnar merged commit b6b8cdd into NixOS:staging May 23, 2018
@jfrankenau jfrankenau deleted the libgudev-gobjectIntrospection branch May 24, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jfrankenau @jtojnar @fpletz @GrahamcOfBorg