Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: Drop 4_x release #35309

Merged
merged 5 commits into from Feb 27, 2018
Merged

nodejs: Drop 4_x release #35309

merged 5 commits into from Feb 27, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Feb 22, 2018 •
edited

Motivation for this change

nodejs-4_x is scheduled end-of-life on 2018-04-30
It should not go in the 18.03 release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis adisbladis changed the title Drop/nodejs 4 x nodejs: Drop 4_x release Feb 22, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘nwjs-0.12.3’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/development/tools/node-webkit/nw12.nix:55 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘nwjs-0.12.3’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/tools/node-webkit/nw12.nix:55 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/ni0988ksbvv96l74cslddm8yylpl2pih-opa-4310/lib  /nix/store/ni0988ksbvv96l74cslddm8yylpl2pih-opa-4310/bin 
patching script interpreter paths in /nix/store/ni0988ksbvv96l74cslddm8yylpl2pih-opa-4310
/nix/store/ni0988ksbvv96l74cslddm8yylpl2pih-opa-4310/bin/opa-plugin-browser: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/ni0988ksbvv96l74cslddm8yylpl2pih-opa-4310/bin/.opa-wrapped: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/ni0988ksbvv96l74cslddm8yylpl2pih-opa-4310/bin/opa-plugin-builder: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/ni0988ksbvv96l74cslddm8yylpl2pih-opa-4310/bin/opa-create: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-opa-4310.drv-0 in /nix/store/ni0988ksbvv96l74cslddm8yylpl2pih-opa-4310...
/nix/store/8izpzvflj7p0xxy7jb4vg3gqyzfgxpd2-nixui-0.2.1
/nix/store/wdd4ma2x1dz36wc08g78n536glzv075q-nodejs-6.13.0
/nix/store/ni0988ksbvv96l74cslddm8yylpl2pih-opa-4310

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/8izpzvflj7p0xxy7jb4vg3gqyzfgxpd2-nixui-0.2.1
/nix/store/wdd4ma2x1dz36wc08g78n536glzv075q-nodejs-6.13.0
/nix/store/ni0988ksbvv96l74cslddm8yylpl2pih-opa-4310

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘nwjs-0.12.3’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/development/tools/node-webkit/nw12.nix:55 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘nwjs-0.12.3’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/tools/node-webkit/nw12.nix:55 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@globin
Copy link
Member

globin commented Feb 22, 2018

👍

ping @vcunat, @fpletz

@globin globin added this to the 18.03 milestone Feb 22, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/8izpzvflj7p0xxy7jb4vg3gqyzfgxpd2-nixui-0.2.1
/nix/store/wdd4ma2x1dz36wc08g78n536glzv075q-nodejs-6.13.0
/nix/store/ni0988ksbvv96l74cslddm8yylpl2pih-opa-4310

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘nwjs-0.12.3’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/tools/node-webkit/nw12.nix:55 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘nwjs-0.12.3’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/tools/node-webkit/nw12.nix:55 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@vcunat
Copy link
Member

vcunat commented Feb 22, 2018

Sounds OK to me. /cc maintainers: @cillianderoiste, @Havvy, @gilligan, @cko.

@adisbladis
Copy link
Member Author

If no one has any opposition I plan to merge this in a day.

CC @cillianderoiste @gilligan @cko

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘nwjs-0.12.3’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/development/tools/node-webkit/nw12.nix:55 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘nwjs-0.12.3’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/tools/node-webkit/nw12.nix:55 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8izpzvflj7p0xxy7jb4vg3gqyzfgxpd2-nixui-0.2.1
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/8izpzvflj7p0xxy7jb4vg3gqyzfgxpd2-nixui-0.2.1/bin 
patching script interpreter paths in /nix/store/8izpzvflj7p0xxy7jb4vg3gqyzfgxpd2-nixui-0.2.1
checking for references to /tmp/nix-build-nixui-0.2.1.drv-0 in /nix/store/8izpzvflj7p0xxy7jb4vg3gqyzfgxpd2-nixui-0.2.1...
/nix/store/8izpzvflj7p0xxy7jb4vg3gqyzfgxpd2-nixui-0.2.1
/nix/store/wdd4ma2x1dz36wc08g78n536glzv075q-nodejs-6.13.0
/nix/store/ni0988ksbvv96l74cslddm8yylpl2pih-opa-4310

@gilligan
Copy link
Contributor

Sounds good to me! Lets drop it!

@globin globin merged commit 4f59f26 into NixOS:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
1.severity: blocker 6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
18.03
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adisbladis @GrahamcOfBorg @globin @vcunat @gilligan