Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: 1.9.3 -> 1.10 #35311

Closed
wants to merge 6 commits into from
Closed

go: 1.9.3 -> 1.10 #35311

wants to merge 6 commits into from

Conversation

velovix
Copy link
Contributor

@velovix velovix commented Feb 22, 2018

Motivation for this change

Go 1.10 has been released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I had to keep Kubernetes using Go 1.9 because the latest stable release doesn't seem to support 1.10.

cloudfoundry-cli seems to refer to Go 1.9 even when using 1.10 for some reason, so I've bumped it down to 1.9 for now. Perhaps someone more versed in the Nix expression language could help me debug this. The error I get is the following:

output ‘/nix/store/a20l7zj2qxr21drd64xhi7xyb8q2apvm-cloudfoundry-cli-6.32.0’ is not allowed to refer to path ‘/nix/store/bwznrnxvnky47w44sd7l3y9ssyxfpgyd-go-1.9.4’

@velovix
go: init 1.10
03ef664
@velovix
go: add velovix as a maintainer for 1.10
87900bf
@velovix
go: Make 1.10 the default & fix dependent packages
af9f585 
It looks like version 1.9.* of Kubernetes does not support Go 1.10 and a
stable release of 1.10 does not exist yet. Once it does, we can upgrade
and depend on Go 1.10.

cloudfoundry-cli seems to forcibly reference Go 1.9 even when upgraded,
I'm not sure why.
@velovix
Merge remote-tracking branch 'upstream/master'
c845452
@velovix
Copy link
Contributor Author

velovix commented Feb 22, 2018

Looks like master is broken right now.

@adisbladis
Copy link
Member

@GrahamcOfBorg eval

@adisbladis
Copy link
Member

@GrahamcOfBorg build go_1_10

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

./src/syscall/mksysnum_dragonfly.pl: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/zdy8xlih8znc7kkgdwhsih504hy8c8w0-perl-5.24.3/bin/perl"
./src/syscall/mksysnum_freebsd.pl: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/zdy8xlih8znc7kkgdwhsih504hy8c8w0-perl-5.24.3/bin/perl"
./src/syscall/mksysnum_linux.pl: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/zdy8xlih8znc7kkgdwhsih504hy8c8w0-perl-5.24.3/bin/perl"
./src/syscall/mksysnum_netbsd.pl: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/zdy8xlih8znc7kkgdwhsih504hy8c8w0-perl-5.24.3/bin/perl"
./src/syscall/mksysnum_openbsd.pl: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/zdy8xlih8znc7kkgdwhsih504hy8c8w0-perl-5.24.3/bin/perl"
./src/syscall/mksysnum_plan9.sh: interpreter directive changed from "/bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
./test/errchk: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/zdy8xlih8znc7kkgdwhsih504hy8c8w0-perl-5.24.3/bin/perl"
sed: can't read misc/cgo/errors/test.bash: No such file or directory
builder for '/nix/store/2kvp8c9dvbznv9rfg8b949jmssg1ql0l-go-1.10.drv' failed with exit code 2
error: build of '/nix/store/2kvp8c9dvbznv9rfg8b949jmssg1ql0l-go-1.10.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/lcc4f6fvisa3651zd4amq5p9r3k45zfh-go-1.10

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
/nix/store/sc1jwmmqwn4hzhjz1bmzv7hryjpzpy9k-go-1.10

@adisbladis adisbladis self-assigned this Feb 22, 2018
@velovix
Copy link
Contributor Author

velovix commented Feb 22, 2018

Unfortunately I don't have a Darwin platform to test on, so I have to take Darwin off the supported platform list for now.

@adisbladis
Copy link
Member

Unfortunately I don't have a Darwin platform to test on, so I have to take Darwin off the supported platform list for now.

I'll have a look of that later today.

@adisbladis adisbladis mentioned this pull request Feb 22, 2018
Merged
8 tasks
@Mic92
Copy link
Member

Mic92 commented Feb 22, 2018

Looks like a race condition. I have made a pull request here as well: #35330
I think (correct me if I am wrong) I have incorporate all changes, you have applied + darwin support.

@velovix
Copy link
Contributor Author

velovix commented Feb 22, 2018

I guess I would have preferred if there was a way to preserve the correct Git blame, maybe by forking against my fork, then having me merge your changes in. That's a lot of process overhead though and I don't blame you for not doing it.

@velovix
Copy link
Contributor Author

velovix commented Feb 22, 2018

Closing in favor of #35330

@velovix velovix closed this Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adisbladis adisbladis

Labels
6.topic: golang 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@velovix @adisbladis @GrahamcOfBorg @Mic92