Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trezor: Add pyblake2, click, libusb1 and ecdsa as propagatedBuildInput #35328

Merged
merged 1 commit into from Feb 22, 2018

Conversation

clefru
Copy link
Contributor

@clefru clefru commented Feb 22, 2018

Motivation for this change

https://github.com/trezor/python-trezor/commits/master/setup.py added lots of dependencies since 0.7.x, which didn't get included in the recent version bump 38116c6

Things done

Build and run bin/trezorctl successfully.
Note that electrum is still broken, and would require a new release after this commit spesmilo/electrum#3621

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

Tested with one of the Trezors in my office.

Works fine.
Thanks!

@adisbladis
Copy link
Member

@clefru I patched electrum in 831ef47 and it seems to work fine with my trezor :)

@clefru
Copy link
Contributor Author

clefru commented Feb 23, 2018

@adisbladis: Your commit is a very nice way of pulling a single patch from a github commit. Works for me. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants