Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix haskellCompilerName version. #35321

Merged
merged 1 commit into from Feb 25, 2018
Merged

Fix haskellCompilerName version. #35321

merged 1 commit into from Feb 25, 2018

Conversation

ElvishJerricco
Copy link
Contributor

@ElvishJerricco ElvishJerricco commented Feb 22, 2018 •
edited

This matters for callCabal2nix, when the cabal file has something like if impl(ghc >= 7.7)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ElvishJerricco
Fix haskellCompilerName version.
a9646b3 
This matters for `callCabal2nix`, when the cabal file has something
like `if impl(ghc >= 7.7)`
@ElvishJerricco
Copy link
Contributor Author

@Ericson2314 Does this match the intended semantics of this field?

peti
peti approved these changes Feb 22, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If this change is fine for the purposes of cross-compilation, too, then I think this should be merged.

@Ericson2314
Copy link
Member

I was surprised it wasn't this to begin with. @bgamari what do you say?

@bgamari
Copy link
Contributor

bgamari commented Feb 25, 2018

Looks reasonable to me.

@ElvishJerricco
Copy link
Contributor Author

Thanks. @peti can you merge this?

@peti peti merged commit ab7a07f into NixOS:master Feb 25, 2018
@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ElvishJerricco @Ericson2314 @bgamari @peti @GrahamcOfBorg