Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awsebcli: 3.12.2 -> 3.12.3 #35315

Merged
merged 1 commit into from Feb 22, 2018
Merged

awsebcli: 3.12.2 -> 3.12.3 #35315

merged 1 commit into from Feb 22, 2018

Conversation

eqyiel
Copy link
Contributor

@eqyiel eqyiel commented Feb 22, 2018

Motivation for this change

New release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

dotlambda
dotlambda approved these changes Feb 22, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things that were not perfect even before this change:

  • You could use oldAttrs.src.override.
  • The description shouldn't contain a period

pkgs/tools/virtualization/awsebcli/default.nix
@@ -67,11 +67,11 @@ let
in with localPython.pkgs; buildPythonApplication rec {
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get rid of the name, it isn't needed anymore.

@adisbladis
Copy link
Member

@GrahamcOfBorg build awsebcli

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/build/awsebcli-3.12.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/85kpw9sbwivb41nmhc0hijv6bi7z74zd-awsebcli-3.12.3
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/85kpw9sbwivb41nmhc0hijv6bi7z74zd-awsebcli-3.12.3/lib  /nix/store/85kpw9sbwivb41nmhc0hijv6bi7z74zd-awsebcli-3.12.3/bin
patching script interpreter paths in /nix/store/85kpw9sbwivb41nmhc0hijv6bi7z74zd-awsebcli-3.12.3
checking for references to /build in /nix/store/85kpw9sbwivb41nmhc0hijv6bi7z74zd-awsebcli-3.12.3...
wrapping `/nix/store/85kpw9sbwivb41nmhc0hijv6bi7z74zd-awsebcli-3.12.3/bin/eb'...
wrapping `/nix/store/85kpw9sbwivb41nmhc0hijv6bi7z74zd-awsebcli-3.12.3/bin/ebp'...
/nix/store/85kpw9sbwivb41nmhc0hijv6bi7z74zd-awsebcli-3.12.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

Requirement already satisfied: docutils>=0.10 in /nix/store/mxrg52ck5vmjvsf3r8rrqr2v20rz5xyq-python2.7-docutils-0.14/lib/python2.7/site-packages (from botocore>=1.0.1->awsebcli==3.12.3)
Installing collected packages: awsebcli
Successfully installed awsebcli-3.12.3
/private/tmp/nix-build-awsebcli-3.12.3.drv-0/awsebcli-3.12.3
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2i59j0bn4r1fv8clqzh7ws04rmaa71px-awsebcli-3.12.3/lib  /nix/store/2i59j0bn4r1fv8clqzh7ws04rmaa71px-awsebcli-3.12.3/bin
patching script interpreter paths in /nix/store/2i59j0bn4r1fv8clqzh7ws04rmaa71px-awsebcli-3.12.3
wrapping `/nix/store/2i59j0bn4r1fv8clqzh7ws04rmaa71px-awsebcli-3.12.3/bin/eb'...
wrapping `/nix/store/2i59j0bn4r1fv8clqzh7ws04rmaa71px-awsebcli-3.12.3/bin/ebp'...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

Successfully installed awsebcli-3.12.3
/tmp/nix-build-awsebcli-3.12.3.drv-0/awsebcli-3.12.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dm9s2kgxb52kyqp1y8g31b6d9sjnpsdw-awsebcli-3.12.3
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/dm9s2kgxb52kyqp1y8g31b6d9sjnpsdw-awsebcli-3.12.3/lib  /nix/store/dm9s2kgxb52kyqp1y8g31b6d9sjnpsdw-awsebcli-3.12.3/bin 
patching script interpreter paths in /nix/store/dm9s2kgxb52kyqp1y8g31b6d9sjnpsdw-awsebcli-3.12.3
checking for references to /tmp/nix-build-awsebcli-3.12.3.drv-0 in /nix/store/dm9s2kgxb52kyqp1y8g31b6d9sjnpsdw-awsebcli-3.12.3...
wrapping `/nix/store/dm9s2kgxb52kyqp1y8g31b6d9sjnpsdw-awsebcli-3.12.3/bin/ebp'...
wrapping `/nix/store/dm9s2kgxb52kyqp1y8g31b6d9sjnpsdw-awsebcli-3.12.3/bin/eb'...

@adisbladis adisbladis merged commit 6e91ce9 into NixOS:master Feb 22, 2018
@adisbladis
Copy link
Member

Thanks!

@eqyiel eqyiel mentioned this pull request Feb 23, 2018
Merged
8 tasks
@eqyiel eqyiel deleted the awsebcli-3.12.3 branch November 3, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eqyiel @adisbladis @GrahamcOfBorg @dotlambda