Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stubby: init at 0.2.2 #36225

Merged
merged 1 commit into from Mar 2, 2018
Merged

stubby: init at 0.2.2 #36225

merged 1 commit into from Mar 2, 2018

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented Mar 2, 2018

Motivation for this change

Previous pull request was autoclosed (#34975)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@leenaars leenaars mentioned this pull request Mar 2, 2018
Merged
8 tasks
shlevy
shlevy approved these changes Mar 2, 2018
View reviewed changes
Copy link
Member

@shlevy shlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, otherwise LGTM pending tests

pkgs/tools/networking/stubby/default.nix Outdated
meta = with stdenv.lib; {
description = "A local DNS Privacy stub resolver (using DNS-over-TLS)";
longDescription = ''
Stubby is an application that acts as a local DNS Privacy stub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Indentation (start two spaces past the l of longDescription

@shlevy
Copy link
Member

shlevy commented Mar 2, 2018

@ofborg build stubby

@shlevy
Copy link
Member

shlevy commented Mar 2, 2018

@GrahamcOfBorg build stubby

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hxn49iq4s9cf6lsi5gk7vfc8j4vqp12m-stubby-0.2.2
shrinking /nix/store/hxn49iq4s9cf6lsi5gk7vfc8j4vqp12m-stubby-0.2.2/bin/stubby
gzipping man pages under /nix/store/hxn49iq4s9cf6lsi5gk7vfc8j4vqp12m-stubby-0.2.2/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hxn49iq4s9cf6lsi5gk7vfc8j4vqp12m-stubby-0.2.2/bin
patching script interpreter paths in /nix/store/hxn49iq4s9cf6lsi5gk7vfc8j4vqp12m-stubby-0.2.2
checking for references to /build in /nix/store/hxn49iq4s9cf6lsi5gk7vfc8j4vqp12m-stubby-0.2.2...
/nix/store/hxn49iq4s9cf6lsi5gk7vfc8j4vqp12m-stubby-0.2.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/tmp/nix-build-stubby-0.2.2.drv-0/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bcbijy6l0bw2jilwv8zs144rcrlzbhvv-stubby-0.2.2
shrinking /nix/store/bcbijy6l0bw2jilwv8zs144rcrlzbhvv-stubby-0.2.2/bin/stubby
gzipping man pages under /nix/store/bcbijy6l0bw2jilwv8zs144rcrlzbhvv-stubby-0.2.2/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bcbijy6l0bw2jilwv8zs144rcrlzbhvv-stubby-0.2.2/bin 
patching script interpreter paths in /nix/store/bcbijy6l0bw2jilwv8zs144rcrlzbhvv-stubby-0.2.2
checking for references to /tmp/nix-build-stubby-0.2.2.drv-0 in /nix/store/bcbijy6l0bw2jilwv8zs144rcrlzbhvv-stubby-0.2.2...
/nix/store/bcbijy6l0bw2jilwv8zs144rcrlzbhvv-stubby-0.2.2

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

#include <Security/Authorization.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [Makefile:388: stubby-ui-helper.o] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-stubby-0.2.2.drv-0/source/macos'
make[1]: *** [Makefile:495: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-stubby-0.2.2.drv-0/source'
make: *** [Makefile:351: all] Error 2
builder for '/nix/store/qqsx466ckbgxag8prz9jy69r2nmpaq1z-stubby-0.2.2.drv' failed with exit code 2
error: build of '/nix/store/qqsx466ckbgxag8prz9jy69r2nmpaq1z-stubby-0.2.2.drv' failed

@shlevy
Copy link
Member

shlevy commented Mar 2, 2018

@leenaars Can you fix ^ or mark unsupported on darwin? You probably just need darwin.Security on darwin.

@leenaars
Copy link
Contributor Author

leenaars commented Mar 2, 2018

Have no access to a Mac, but I followed your advice - so let's see if that works. Otherwise I'll mark as broken.

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2018

@GrahamcOfBorg build stubby

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/bcbijy6l0bw2jilwv8zs144rcrlzbhvv-stubby-0.2.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/hxn49iq4s9cf6lsi5gk7vfc8j4vqp12m-stubby-0.2.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

make[2]: Leaving directory '/private/tmp/nix-build-stubby-0.2.2.drv-0/source'
make[1]: Leaving directory '/private/tmp/nix-build-stubby-0.2.2.drv-0/source'
post-installation fixup
gzipping man pages under /nix/store/nh8kixsa7r0am67dq9zgs5lpcxp8q830-stubby-0.2.2/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/nh8kixsa7r0am67dq9zgs5lpcxp8q830-stubby-0.2.2/bin  /nix/store/nh8kixsa7r0am67dq9zgs5lpcxp8q830-stubby-0.2.2/sbin
patching script interpreter paths in /nix/store/nh8kixsa7r0am67dq9zgs5lpcxp8q830-stubby-0.2.2
/nix/store/nh8kixsa7r0am67dq9zgs5lpcxp8q830-stubby-0.2.2/sbin/stubby-setdns-macos.sh: interpreter directive changed from "/bin/bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
moving /nix/store/nh8kixsa7r0am67dq9zgs5lpcxp8q830-stubby-0.2.2/sbin/* to /nix/store/nh8kixsa7r0am67dq9zgs5lpcxp8q830-stubby-0.2.2/bin
/nix/store/nh8kixsa7r0am67dq9zgs5lpcxp8q830-stubby-0.2.2

@Mic92 Mic92 merged commit bf40da7 into NixOS:master Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy shlevy approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leenaars @shlevy @GrahamcOfBorg @Mic92