Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1709 xscreensaver #36208

Merged
merged 2 commits into from Mar 2, 2018
Merged

1709 xscreensaver #36208

merged 2 commits into from Mar 2, 2018

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Mar 2, 2018 •
edited

Motivation for this change

The old version displays warnings, asking for an upgrade.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

7c6f434c and others added 2 commits March 2, 2018 12:25
@7c6f434c @tokudan
xscreensaver: 5.36 -> 5.37
036bcb7 
(cherry picked from commit 6b9b8b1)
@mogorman @tokudan
xscreensaver: 5.37 -> 5.38
7ac8557 
(cherry picked from commit 8bc2025)

Also update links from http to https (selectively taken from 7b97c8c).
@Mic92
Copy link
Member

Mic92 commented Mar 2, 2018

@GrahamcOfBorg build xscreensaver

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘linux-pam-1.2.1’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/pam/default.nix:53 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/psxzh3ghxiqkmsxd8283hw5r2r223g05-xscreensaver-5.38/libexec/xscreensaver/glblur
shrinking /nix/store/psxzh3ghxiqkmsxd8283hw5r2r223g05-xscreensaver-5.38/libexec/xscreensaver/pipes
shrinking /nix/store/psxzh3ghxiqkmsxd8283hw5r2r223g05-xscreensaver-5.38/libexec/xscreensaver/qix
shrinking /nix/store/psxzh3ghxiqkmsxd8283hw5r2r223g05-xscreensaver-5.38/libexec/xscreensaver/crackberg
shrinking /nix/store/psxzh3ghxiqkmsxd8283hw5r2r223g05-xscreensaver-5.38/libexec/xscreensaver/molecule
gzipping man pages under /nix/store/psxzh3ghxiqkmsxd8283hw5r2r223g05-xscreensaver-5.38/share/man/
stripping (with flags -S) in /nix/store/psxzh3ghxiqkmsxd8283hw5r2r223g05-xscreensaver-5.38/libexec  /nix/store/psxzh3ghxiqkmsxd8283hw5r2r223g05-xscreensaver-5.38/bin 
patching script interpreter paths in /nix/store/psxzh3ghxiqkmsxd8283hw5r2r223g05-xscreensaver-5.38
/nix/store/psxzh3ghxiqkmsxd8283hw5r2r223g05-xscreensaver-5.38/libexec/xscreensaver/ljlatest: interpreter directive changed from "/bin/sh" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-xscreensaver-5.38.drv-0 in /nix/store/psxzh3ghxiqkmsxd8283hw5r2r223g05-xscreensaver-5.38...

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/9ffjwzkx5a25knxdyblik3ykkpnwcxyi-cups-2.2.2-dev/bin/cups-config: interpreter directive changed from "/bin/sh" to "/nix/store/7b94zsymp6g5rzp2pgwhpkw0idjg52x5-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/9ffjwzkx5a25knxdyblik3ykkpnwcxyi-cups-2.2.2-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/63jhdhrjb9waxarxsak4baddznxrjzra-cups-2.2.2-man
gzipping man pages under /nix/store/63jhdhrjb9waxarxsak4baddznxrjzra-cups-2.2.2-man/share/man/
patching script interpreter paths in /nix/store/63jhdhrjb9waxarxsak4baddznxrjzra-cups-2.2.2-man
checking for references to /build in /nix/store/63jhdhrjb9waxarxsak4baddznxrjzra-cups-2.2.2-man...
cannot build derivation '/nix/store/8w3iqd8jvrzfw0kkxiyk4flrwxj2wizf-gtk+-2.24.31.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/gl502466571hx6y3snrncijff34lji8q-libglade-2.6.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ax8lxzyf1ipbn9x78fm2vic528vgq5p7-xscreensaver-5.38.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/ax8lxzyf1ipbn9x78fm2vic528vgq5p7-xscreensaver-5.38.drv' failed

@7c6f434c 7c6f434c merged commit f36b701 into NixOS:release-17.09 Mar 2, 2018
@7c6f434c
Copy link
Member

7c6f434c commented Mar 2, 2018

Thanks for bringing this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tokudan @Mic92 @GrahamcOfBorg @7c6f434c @mogorman