Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: 7.1.14 -> 7.1.15, 5.6.33 -> 5.6.34 #36209

Merged
merged 3 commits into from Mar 4, 2018
Merged

php: 7.1.14 -> 7.1.15, 5.6.33 -> 5.6.34 #36209

merged 3 commits into from Mar 4, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Mar 2, 2018 •
edited

Motivation for this change

A bunch of security fixes and bug fixes.

Also added myself to the list of php maintainers.

This shuould be the last updates of this months releases.

cc @globin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 2, 2018
@etu
Copy link
Contributor Author

etu commented Mar 3, 2018

Port to stable should have been done for #36174 as well, but I don't think it was.

@obadz obadz merged commit edc7ca8 into NixOS:master Mar 4, 2018
@obadz
Copy link
Contributor

obadz commented Mar 4, 2018

@etu, would you mind opening a PR against 17.09 cherry-picking what you think should be ported?

@fpletz
Copy link
Member

fpletz commented Mar 4, 2018

I can take care of the cherry-picking. Thank you both!

@fpletz
Copy link
Member

fpletz commented Mar 4, 2018

c143dea...848a465

@obadz
Copy link
Contributor

obadz commented Mar 4, 2018

@fpletz, thanks to you!

@etu etu deleted the php-updates branch March 5, 2018 06:56
@etu
Copy link
Contributor Author

etu commented Mar 5, 2018

@fpletz That's perfect, thanks :)

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@etu @obadz @fpletz @Mic92 @samueldr @GrahamcOfBorg