Py junos eznc #36215

xnaveira · 2018-03-02T14:37:03Z

Motivation for this change

Some Pypi packages I was missing.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92 · 2018-03-02T14:46:44Z

pkgs/development/python-modules/junos-eznc/default.nix

+  };
+
+  buildInputs = [
+    scp six pyserial paramiko netaddr ncclient lxml jinja2 pyyaml


Are all those dependencies only needed at build time of the package? All python dependencies that are needed at runtime, should be also in propagatedBuildInputs.

Mic92 · 2018-03-02T14:47:04Z

pkgs/development/python-modules/ncclient/default.nix

+
+  buildInputs = [
+    setuptools paramiko lxml libxml2 libxslt
+  ];


Mic92 · 2018-03-02T14:47:28Z

pkgs/development/python-modules/scp/default.nix

+
+
+  buildInputs = [
+    paramiko


xnaveira · 2018-03-02T17:43:35Z

Ok, changed the dependencies, apparently they are not needed to build.

dotlambda

Please ensure that tests are run for each package, if it provides some. You may have to set checkInputs and checkPhase.
If there are no tests, add the following lines:

# no tests implemented
doCheck = false;

dotlambda · 2018-03-02T20:00:04Z

pkgs/top-level/python-packages.nix

+
+  ncclient = callPackage ../development/python-modules/ncclient {};
+
+  junos-eznc = callPackage ../development/python-modules/junos-eznc {};


The attributes in python-packages.nix should be ordered alphabetically.

dotlambda · 2018-03-02T20:01:25Z

pkgs/development/python-modules/scp/default.nix

+
+  meta = with stdenv.lib; {
+    homepage = https://github.com/jbardin/scp.py;
+    description = "scp module for paramiko";


Capitalize first letter (or even SCP in this case): https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

The name of scp seems to be lowercase scp, not capitalised even at the beginning of a sentence, at least in its manpage. I think this seems a reasonable place not to apply the rule blindly.

dotlambda · 2018-03-02T20:02:14Z

pkgs/development/python-modules/ncclient/default.nix

+
+
+  propagatedBuildInputs = [
+    setuptools paramiko lxml libxml2 libxslt


setuptools should not be needed here

dotlambda · 2018-03-02T20:03:17Z

pkgs/development/python-modules/scp/default.nix

+, buildPythonPackage
+, fetchPypi
+, pythonPackages
+, setuptools


pythonPackages.junos-eznc: init at 2.1.7 pythonPackages.junos-eznc: init at 2.1.7

xnaveira · 2018-03-03T16:59:12Z

Ok, I went through your comments. Thanks for pointing out the problems.

Mic92 · 2018-03-03T17:03:19Z

@GrahamcOfBorg build python36Packages.scp python27Packages.ncclient python27Packages.scp python27Packages.junos-eznc

GrahamcOfBorg · 2018-03-03T17:04:19Z

Success on aarch64-linux (full log)

Partial log (click to expand)

-------------------------------------------------------------------------
TOTAL                                                  4595   3371    27%
/nix/store/0r3fn1v2d5q0nvd03da4hkxrb3i8zv3y-python3.6-scp-0.10.2
/nix/store/dhmd4vnm2v7877yfbbrbrbw9mwla95ix-python2.7-ncclient-0.5.3
/nix/store/q3k6jkcydzphdgqk1wba88mr6w00la4n-python2.7-scp-0.10.2
----------------------------------------------------------------------
/nix/store/gvwlgxyl1sa00mw0nqwsg6xy5jc73p02-python2.7-junos-eznc-2.1.7
Ran 0 tests in 2.769s

OK

GrahamcOfBorg · 2018-03-03T17:12:36Z

Success on x86_64-linux (full log)

Partial log (click to expand)

-------------------------------------------------------------------------
TOTAL                                                  4595   3371    27%
/nix/store/vyx66ffzmh7q37c7nh5y7kcxndb104h0-python3.6-scp-0.10.2
/nix/store/99qac76pv5iid85nzslpbni0rsp35kwq-python2.7-ncclient-0.5.3
/nix/store/w1z6gvxf5vyi6m8nkkll5rv67pql7idw-python2.7-scp-0.10.2
----------------------------------------------------------------------
/nix/store/9jdqzzz9v540fpnf8i26a9kigabq9ljv-python2.7-junos-eznc-2.1.7
Ran 0 tests in 0.748s

OK

GrahamcOfBorg · 2018-03-03T17:33:51Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

patching script interpreter paths in /nix/store/svypmqgkb67lsy0lrm8lp3niava3nl07-python3.6-scp-0.10.2
Successfully installed ncclient-0.5.3
/private/tmp/nix-build-python2.7-ncclient-0.5.3.drv-0/ncclient-0.5.3
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/dhngdiyjrjw14s6l6c667x02x1yv6vqn-python2.7-ncclient-0.5.3/lib
patching script interpreter paths in /nix/store/dhngdiyjrjw14s6l6c667x02x1yv6vqn-python2.7-ncclient-0.5.3
building of '/nix/store/hvwn8fn6lidr011izvs4cjcllz18046w-python2.7-pyserial-3.4.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/ji9fm886kgzjc9frr8i98yj043jwdn8j-python2.7-junos-eznc-2.1.7.drv': 1 dependencies couldn't be built
error: build of '/nix/store/ji9fm886kgzjc9frr8i98yj043jwdn8j-python2.7-junos-eznc-2.1.7.drv' failed

Xavier Naveira added 2 commits March 2, 2018 15:24

pythonPackages.scp: init at 0.10.2

284c6a5

pythonPackages.ncclient: init a 0.5.3

22c5082

xnaveira requested a review from FRidh as a code owner March 2, 2018 14:37

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 2, 2018

Mic92 reviewed Mar 2, 2018

View reviewed changes

pkgs/development/python-modules/ncclient/default.nix Outdated

buildInputs = [

setuptools paramiko lxml libxml2 libxslt

];

Copy link

Member

Mic92 Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

Mic92 reviewed Mar 2, 2018

View reviewed changes

pkgs/development/python-modules/scp/default.nix Outdated

buildInputs = [

paramiko

Copy link

Member

Mic92 Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

dotlambda requested changes Mar 2, 2018

View reviewed changes

pythonPackages.junos-eznc: init at 2.1.7

1689c3c

pythonPackages.junos-eznc: init at 2.1.7 pythonPackages.junos-eznc: init at 2.1.7

xnaveira force-pushed the py-junos-eznc branch from 53d476d to 1689c3c Compare March 3, 2018 16:53

Mic92 merged commit fe2acc2 into NixOS:master Mar 3, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Py junos eznc #36215

Py junos eznc #36215

xnaveira commented Mar 2, 2018 •

edited

Mic92 Mar 2, 2018

Mic92 Mar 2, 2018

Mic92 Mar 2, 2018

xnaveira commented Mar 2, 2018

dotlambda left a comment

dotlambda Mar 2, 2018

dotlambda Mar 2, 2018

lheckemann Mar 3, 2018

dotlambda Mar 2, 2018

dotlambda Mar 2, 2018

xnaveira commented Mar 3, 2018 •

edited

Mic92 commented Mar 3, 2018

GrahamcOfBorg commented Mar 3, 2018

GrahamcOfBorg commented Mar 3, 2018

GrahamcOfBorg commented Mar 3, 2018


		ncclient = callPackage ../development/python-modules/ncclient {};

		junos-eznc = callPackage ../development/python-modules/junos-eznc {};



		propagatedBuildInputs = [
		setuptools paramiko lxml libxml2 libxslt

Py junos eznc #36215

Py junos eznc #36215

Conversation

xnaveira commented Mar 2, 2018 • edited

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xnaveira commented Mar 2, 2018

dotlambda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xnaveira commented Mar 3, 2018 • edited

Mic92 commented Mar 3, 2018

GrahamcOfBorg commented Mar 3, 2018

GrahamcOfBorg commented Mar 3, 2018

GrahamcOfBorg commented Mar 3, 2018

xnaveira commented Mar 2, 2018 •

edited

xnaveira commented Mar 3, 2018 •

edited