Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.callCabal2nix: Depend on the expression. #36216

Merged
merged 1 commit into from Mar 2, 2018

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Mar 2, 2018

This ensures that as long as the package derivation is alive, its nix
expressions do not need to be regenerated.

Fixes #36190.

This ensures that as long as the package derivation is alive, its nix
expressions do not need to be regenerated.

Fixes NixOS#36190.
@shlevy shlevy requested a review from peti March 2, 2018 14:39
@shlevy
Copy link
Member Author

shlevy commented Mar 2, 2018

@ElvishJerricco

Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I haven't tested it, though.

@shlevy shlevy merged commit 62a1abe into NixOS:master Mar 2, 2018
@shlevy shlevy deleted the callCabal2nix-retain-ifd branch March 2, 2018 18:26
@ElvishJerricco
Copy link
Contributor

This is perfect :) Thanks @shlevy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants