Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corebird: 1.7.3 -> 1.7.4 #36222

Merged
merged 0 commits into from Mar 2, 2018
Merged

corebird: 1.7.3 -> 1.7.4 #36222

merged 0 commits into from Mar 2, 2018

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Mar 2, 2018

Motivation for this change

Coredbird has a new bugfix release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 2, 2018

Changelog: https://github.com/baedert/corebird/releases/tag/1.7.4

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2018

@GrahamcOfBorg build corebird

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘corebird-1.7.4’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/networking/corebird/default.nix:27 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

jtojnar
jtojnar approved these changes Mar 2, 2018
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs fine.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/c4w4fqvm31afrhhshhpd1czzyva7dzz5-corebird-1.7.4/bin/corebird
shrinking RPATHs of ELF executables and libraries in /nix/store/c4w4fqvm31afrhhshhpd1czzyva7dzz5-corebird-1.7.4
shrinking /nix/store/c4w4fqvm31afrhhshhpd1czzyva7dzz5-corebird-1.7.4/bin/.corebird-wrapped
gzipping man pages under /nix/store/c4w4fqvm31afrhhshhpd1czzyva7dzz5-corebird-1.7.4/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/c4w4fqvm31afrhhshhpd1czzyva7dzz5-corebird-1.7.4/bin 
patching script interpreter paths in /nix/store/c4w4fqvm31afrhhshhpd1czzyva7dzz5-corebird-1.7.4
checking for references to /tmp/nix-build-corebird-1.7.4.drv-0 in /nix/store/c4w4fqvm31afrhhshhpd1czzyva7dzz5-corebird-1.7.4...
/nix/store/c4w4fqvm31afrhhshhpd1czzyva7dzz5-corebird-1.7.4

@jtojnar jtojnar closed this Mar 2, 2018
@Mic92 Mic92 merged commit 004a59f into NixOS:master Mar 2, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/2cm022bnpjn8f3fqf4d8zkrk6qs9jzcr-corebird-1.7.4/bin/corebird
shrinking RPATHs of ELF executables and libraries in /nix/store/2cm022bnpjn8f3fqf4d8zkrk6qs9jzcr-corebird-1.7.4
shrinking /nix/store/2cm022bnpjn8f3fqf4d8zkrk6qs9jzcr-corebird-1.7.4/bin/.corebird-wrapped
gzipping man pages under /nix/store/2cm022bnpjn8f3fqf4d8zkrk6qs9jzcr-corebird-1.7.4/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2cm022bnpjn8f3fqf4d8zkrk6qs9jzcr-corebird-1.7.4/bin
patching script interpreter paths in /nix/store/2cm022bnpjn8f3fqf4d8zkrk6qs9jzcr-corebird-1.7.4
checking for references to /build in /nix/store/2cm022bnpjn8f3fqf4d8zkrk6qs9jzcr-corebird-1.7.4...
/nix/store/2cm022bnpjn8f3fqf4d8zkrk6qs9jzcr-corebird-1.7.4

@jonafato jonafato deleted the corebird-1.7.4 branch March 2, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonafato @jtojnar @Mic92 @GrahamcOfBorg