Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PDLPorters/pdl
base: 8fe8cb50602f
Choose a base ref
...
head repository: PDLPorters/pdl
compare: 246115e89301
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Mar 9, 2018

  1. Add tilde filename expansion to rfits/wfits 

    We use the same tilde expansion that is used in PDL::AutoLoader,
so there should be no (additional) portability issues.

It would probably be better to put this into a new IO.pm module
and then all the PDL::IO::* modules could use it.
    @d-lamb
    d-lamb committed Mar 9, 2018
    Copy the full SHA
    844cfd4 View commit details
    Browse the repository at this point in the history

  2. Make the fits tilde expansion more cross-platform friendly. 

    Instead of the pwnam etc which is not super portable, we can
use glob(~) to get the home directory.  That should be more portable.

Alternatively we could add a dependency and use File::HomeDir.
    @d-lamb
    d-lamb committed Mar 9, 2018
    Copy the full SHA
    39c2f19 View commit details
    Browse the repository at this point in the history

  3. Use Test::Exception and lives_ok instead of eval in some FITS tests.

    @d-lamb
    d-lamb committed Mar 9, 2018
    Copy the full SHA
    246115e View commit details
    Browse the repository at this point in the history