Skip to content

Commit

Permalink
Cleanup: drop Server::hudGetHotbarItemcount()
Browse files Browse the repository at this point in the history
Call directly accessible RemotePlayer::getHotbarItemcount() from server api
  • Loading branch information
nerzhul committed Mar 8, 2018
1 parent f35236a commit 373f1bf
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
4 changes: 1 addition & 3 deletions src/script/lua_api/l_object.cpp
Expand Up @@ -1462,9 +1462,7 @@ int ObjectRef::l_hud_get_hotbar_itemcount(lua_State *L)
if (player == NULL)
return 0;

s32 hotbar_itemcount = getServer(L)->hudGetHotbarItemcount(player);

lua_pushnumber(L, hotbar_itemcount);
lua_pushnumber(L, player->getHotbarItemcount());
return 1;
}

Expand Down
7 changes: 1 addition & 6 deletions src/server.cpp
Expand Up @@ -317,7 +317,7 @@ Server::~Server()

{
MutexAutoLock envlock(m_env_mutex);

infostream << "Server: Saving players" << std::endl;
m_env->saveLoadedPlayers();

Expand Down Expand Up @@ -3090,11 +3090,6 @@ bool Server::hudSetHotbarItemcount(RemotePlayer *player, s32 hotbar_itemcount)
return true;
}

s32 Server::hudGetHotbarItemcount(RemotePlayer *player) const
{
return player->getHotbarItemcount();
}

void Server::hudSetHotbarImage(RemotePlayer *player, std::string name)
{
if (!player)
Expand Down
1 change: 0 additions & 1 deletion src/server.h
Expand Up @@ -290,7 +290,6 @@ class Server : public con::PeerHandler, public MapEventReceiver,
bool hudChange(RemotePlayer *player, u32 id, HudElementStat stat, void *value);
bool hudSetFlags(RemotePlayer *player, u32 flags, u32 mask);
bool hudSetHotbarItemcount(RemotePlayer *player, s32 hotbar_itemcount);
s32 hudGetHotbarItemcount(RemotePlayer *player) const;
void hudSetHotbarImage(RemotePlayer *player, std::string name);
std::string hudGetHotbarImage(RemotePlayer *player);
void hudSetHotbarSelectedImage(RemotePlayer *player, std::string name);
Expand Down

0 comments on commit 373f1bf

Please sign in to comment.