Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

znc: 1.6.5 -> 1.6.6 #36596

Closed
wants to merge 1 commit into from
Closed

znc: 1.6.5 -> 1.6.6 #36596

wants to merge 1 commit into from

Conversation

mdsib
Copy link

@mdsib mdsib commented Mar 9, 2018

Motivation for this change

This version of znc fixes --makepem segfault. See the changelog here: znc 1.6.6 changelog

Additionally, this change keeps service's file configuration's Version up to date with znc's version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mdsib
znc: 1.6.5 -> 1.6.6
8d83fbc 
This version of znc fixes `--makepem` segfault.
@infinisil
Copy link
Member

The bots are taking our jobs! #37146

But the module update would still be needed. In addition I found out that parallel building can be enabled for znc ("if you are on a dedicated server and your CPU has more than one core, you can use make -jX where X is the number of CPU cores to speed up compilation"). Those things could be done in a single PR.

@mdsib
Copy link
Author

mdsib commented Mar 25, 2018

Sounds good. Were you thinking of making that a configurable option, or filling it with the result of nproc or something like that?

@infinisil
Copy link
Member

@mdsib Just add enableParallelBuilding = true; to the derivation :)

@globin
Copy link
Member

globin commented Mar 30, 2018

This PR is conlicting

@mdsib
Copy link
Author

mdsib commented Mar 30, 2018 •
edited

Yeah, closing. I'll put up another with updates to the module soon.
Edit: Unless I should just modify this one? Not sure what's proper for this repo.

@mdsib mdsib closed this Mar 30, 2018
@mdsib mdsib deleted the znc-1.6.6 branch October 9, 2019 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mdsib @infinisil @globin @GrahamcOfBorg @Janik-Haag