Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mitmproxy #35514

Merged
merged 2 commits into from Feb 25, 2018
Merged

Fix mitmproxy #35514

merged 2 commits into from Feb 25, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 25, 2018

Motivation for this change

#35499

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using (none)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@7c6f434c 7c6f434c requested a review from fpletz February 25, 2018 02:26
@fpletz
Copy link
Member

fpletz commented Feb 25, 2018

Thanks!

@fpletz fpletz merged commit f4a0c57 into NixOS:master Feb 25, 2018
@FRidh FRidh mentioned this pull request Feb 25, 2018
Closed
@rnhmjoj rnhmjoj deleted the mitm branch February 23, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @fpletz @7c6f434c @GrahamcOfBorg