Implement the Cohen-Hubbard-Oesterwinter method #1734

pleroy · 2018-02-25T14:04:48Z

This brings significant improvements in accuracy and in speed:
Before:

---------------------------------------------------------------------------------
Benchmark                                          Time           CPU Iterations
---------------------------------------------------------------------------------
BM_EphemerisSolarSystemMajorBodiesOnly/-3 90719773589 ns 90371379300 ns          1 +9.92179030813603147e-01 ua

After:

---------------------------------------------------------------------------------
Benchmark                                          Time           CPU Iterations
---------------------------------------------------------------------------------
BM_EphemerisSolarSystemMajorBodiesOnly/-3 55156286341 ns 54912352000 ns          1 +9.92179030813603147e-01 ua

eggrobin · 2018-02-25T14:30:26Z

integrators/symmetric_linear_multistep_integrator_test.cpp

 #endif
  double const v_convergence_order = Slope(log_step_sizes, log_p_errors);
  double const v_correlation =
      PearsonProductMomentCorrelationCoefficient(log_step_sizes, log_p_errors);
  LOG(INFO) << "Convergence order in p : " << v_convergence_order;
  LOG(INFO) << "Correlation            : " << v_correlation;
 #if !defined(_DEBUG)
-  EXPECT_THAT(RelativeError(integrator.order, v_convergence_order), Lt(0.035));
-  EXPECT_THAT(v_correlation, IsNear(1.0, /*tolerance=*/1.02));
+  EXPECT_THAT(RelativeError(integrator.order, v_convergence_order), Lt(0.02));


Should the matcher be IsNear rather than Lt here and above?

As discussed, this doesn't work too well.

pleroy added 3 commits February 25, 2018 11:53

Implement the Cohen-Hubbard-Oesterwinter method.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

abbc61f

Use the right order.

7d2557b

Merge branch 'master' into Velocity2

d8181db

eggrobin approved these changes Feb 25, 2018

View reviewed changes

eggrobin added the LGTM label Feb 25, 2018

Tolerances.

2123eda

pleroy merged commit 41def18 into mockingbirdnest:master Feb 25, 2018

pleroy mentioned this pull request Mar 3, 2018

Bizarre trajectories in frames tied to Pol #1741

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement the Cohen-Hubbard-Oesterwinter method #1734

Implement the Cohen-Hubbard-Oesterwinter method #1734

pleroy commented Feb 25, 2018

eggrobin Feb 25, 2018

pleroy Feb 25, 2018

Implement the Cohen-Hubbard-Oesterwinter method #1734

Implement the Cohen-Hubbard-Oesterwinter method #1734

Conversation

pleroy commented Feb 25, 2018

eggrobin Feb 25, 2018

Choose a reason for hiding this comment

pleroy Feb 25, 2018

Choose a reason for hiding this comment