udisks2: add gobjectIntrospection to nativeBuildInputs #35476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this case the GIR file is 1.3 MB so it should go to a |
jfrankenau
force-pushed
the
udisks2-gobjectIntrospection
branch
from
7d24a78
to
dc2f0c7
Compare
|
Done. |
jtojnar
requested changes
Feb 24, 2018
| @@ -38,6 +39,11 @@ stdenv.mkDerivation rec { | |||
| "--with-udevdir=$(out)/lib/udev" | |||
| ]; | |||
|
|
|||
| makeFlags = [ | |||
| "INTROSPECTION_GIRDIR=$(out)/share/gir-1.0" | |||
There was a problem hiding this comment.
The GIR file is moved in gobjectIntrospection setup hook but we should still use dev instead of out here.
There was a problem hiding this comment.
Ah, missed that one. Should be fixed now.
jfrankenau
force-pushed
the
udisks2-gobjectIntrospection
branch
from
dc2f0c7
to
40c0659
Compare
jtojnar
force-pushed
the
udisks2-gobjectIntrospection
branch
from
40c0659
to
f19f671
Compare
jtojnar
force-pushed
the
udisks2-gobjectIntrospection
branch
from
f19f671
to
2cc5ac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Same as in #35335.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)