Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cairocffi: 0.7.2 → 0.8.0 #35527

Merged
merged 2 commits into from Feb 27, 2018
Merged

pythonPackages.cairocffi: 0.7.2 → 0.8.0 #35527

merged 2 commits into from Feb 27, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 25, 2018 •
edited

Motivation for this change

Update and move out of python-modules.nix.

https://github.com/Kozea/cairocffi/blob/9cba2e6039869db6710a5fb6a1af0f139509fc00/CHANGES#L7-L19

Things done

I ran qtile (the only thing depending on this) in VM and it seemed to work fine.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar requested a review from FRidh as a code owner February 25, 2018 05:31
@dotlambda
Copy link
Member

dotlambda commented Feb 25, 2018 •
edited

@GrahamcOfBorg build python2.pkgs.cairocffi python3.pkgs.cairocffi

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

error: attribute ‘cairocffi-xcffib’ in selection path ‘python2.pkgs.cairocffi-xcffib’ not found

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

�[31;1merror:�[0m attribute 'cairocffi-xcffib' in selection path 'python2.pkgs.cairocffi-xcffib' not found

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

collected 42 items / 1 skipped

../../../nix/store/i3drmlb9xjvfjqlvbrsbw89mnh51cbrm-python3.6-cairocffi-0.8.0/lib/python3.6/site-packages/cairocffi/test_cairo.py . [  2%]
.....................................                                    [ 90%]
../../../nix/store/i3drmlb9xjvfjqlvbrsbw89mnh51cbrm-python3.6-cairocffi-0.8.0/lib/python3.6/site-packages/cairocffi/test_pixbuf.py . [ 92%]
x..                                                                      [100%]

=============== 41 passed, 1 skipped, 1 xfailed in 0.68 seconds ================
/nix/store/3mfddj70x7l0g3kpdv9xw37vap1zyfd8-python2.7-cairocffi-0.8.0
/nix/store/i3drmlb9xjvfjqlvbrsbw89mnh51cbrm-python3.6-cairocffi-0.8.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

collected 42 items / 1 skipped

../../nix/store/iyq1j6sf42anb5yh0fdnqsak8sfgnf2f-python3.6-cairocffi-0.8.0/lib/python3.6/site-packages/cairocffi/test_cairo.py . [  2%]
.....................................                                    [ 90%]
../../nix/store/iyq1j6sf42anb5yh0fdnqsak8sfgnf2f-python3.6-cairocffi-0.8.0/lib/python3.6/site-packages/cairocffi/test_pixbuf.py . [ 92%]
x..                                                                      [100%]

=============== 41 passed, 1 skipped, 1 xfailed in 2.45 seconds ================
/nix/store/86g23ahypsba4isnjny46qscbr1lxc2b-python2.7-cairocffi-0.8.0
/nix/store/iyq1j6sf42anb5yh0fdnqsak8sfgnf2f-python3.6-cairocffi-0.8.0

@dotlambda
Copy link
Member

@GrahamcOfBorg build qtile

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

gzipping man pages under /nix/store/7xmpzcyv6ir3l9x1xxykg2s93l5xmi3w-qtile-0.10.7/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/7xmpzcyv6ir3l9x1xxykg2s93l5xmi3w-qtile-0.10.7/lib  /nix/store/7xmpzcyv6ir3l9x1xxykg2s93l5xmi3w-qtile-0.10.7/bin 
patching script interpreter paths in /nix/store/7xmpzcyv6ir3l9x1xxykg2s93l5xmi3w-qtile-0.10.7
/nix/store/7xmpzcyv6ir3l9x1xxykg2s93l5xmi3w-qtile-0.10.7/bin/iqshell: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-qtile-0.10.7.drv-0 in /nix/store/7xmpzcyv6ir3l9x1xxykg2s93l5xmi3w-qtile-0.10.7...
wrapping `/nix/store/7xmpzcyv6ir3l9x1xxykg2s93l5xmi3w-qtile-0.10.7/bin/qtile-run'...
wrapping `/nix/store/7xmpzcyv6ir3l9x1xxykg2s93l5xmi3w-qtile-0.10.7/bin/.qtile-wrapped'...
wrapping `/nix/store/7xmpzcyv6ir3l9x1xxykg2s93l5xmi3w-qtile-0.10.7/bin/qtile-top'...
wrapping `/nix/store/7xmpzcyv6ir3l9x1xxykg2s93l5xmi3w-qtile-0.10.7/bin/qshell'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hh129az14s4mjp50gfwrf0886yrmdm90-qtile-0.10.7/lib  /nix/store/hh129az14s4mjp50gfwrf0886yrmdm90-qtile-0.10.7/bin
patching script interpreter paths in /nix/store/hh129az14s4mjp50gfwrf0886yrmdm90-qtile-0.10.7
/nix/store/hh129az14s4mjp50gfwrf0886yrmdm90-qtile-0.10.7/bin/iqshell: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/hh129az14s4mjp50gfwrf0886yrmdm90-qtile-0.10.7...
wrapping `/nix/store/hh129az14s4mjp50gfwrf0886yrmdm90-qtile-0.10.7/bin/.qtile-wrapped'...
wrapping `/nix/store/hh129az14s4mjp50gfwrf0886yrmdm90-qtile-0.10.7/bin/qtile-run'...
wrapping `/nix/store/hh129az14s4mjp50gfwrf0886yrmdm90-qtile-0.10.7/bin/qshell'...
wrapping `/nix/store/hh129az14s4mjp50gfwrf0886yrmdm90-qtile-0.10.7/bin/qtile-top'...
/nix/store/hh129az14s4mjp50gfwrf0886yrmdm90-qtile-0.10.7

dotlambda
dotlambda reviewed Feb 25, 2018
View reviewed changes
pkgs/development/python-modules/cairocffi/default.nix Outdated

# FIXME: make gdk_pixbuf dependency optional
# Happens with 0.7.1 and 0.7.2
# OSError: dlopen() failed to load a library: gdk_pixbuf-2.0 / gdk_pixbuf-2.0-0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested whether this is still a problem?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @avnik and @FRidh, who wrote these comments, can tell us more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure how to reproduce that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it, this probably talks about the reason for patch, not an another thing to fix. I should move the FIXME comment elsewhere, to make it less confusing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And ignore drop the version info, it will happen as long as they do not use absolute paths.

@jtojnar jtojnar merged commit 1bdca01 into NixOS:master Feb 27, 2018
@jtojnar jtojnar deleted the cairocffi branch February 28, 2018 15:19
@jtojnar jtojnar mentioned this pull request Jun 1, 2018
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @dotlambda @GrahamcOfBorg