Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hy: 0.13.1 -> 0.14.0 #35487

Merged
merged 1 commit into from Mar 4, 2018
Merged

hy: 0.13.1 -> 0.14.0 #35487

merged 1 commit into from Mar 4, 2018

Conversation

nixy
Copy link
Contributor

@nixy nixy commented Feb 24, 2018 •
edited

Motivation for this change

Updating hy for the new release.

The preConfigure hook is pretty gross and I'd like some input on a better way to do this if it's possible. To be specific the build process uses rply to generate a parser and output it at ~/.cache/rply/hy_parser-$hash_of_something.json.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 4, 2018

@GrahamcOfBorg build hy

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

reading manifest file 'hy.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'hy.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/jiyqv411b6xs9gc7snrl71n896ppxdvn-hy-0.14.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

reading manifest file 'hy.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'hy.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/p8p2b3y0mls15prz9bszqrbi9bj3id77-hy-0.14.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

reading manifest file 'hy.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'hy.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/5xv4av77nsmx6j14x11z3dmp088ln1ar-hy-0.14.0

@Mic92 Mic92 merged commit c2eabe9 into NixOS:master Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nixy @Mic92 @GrahamcOfBorg