Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udisks: point to udisks2 #35492

Merged
merged 3 commits into from Feb 28, 2018
Merged

udisks: point to udisks2 #35492

merged 3 commits into from Feb 28, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 24, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘spacefm-1.0.5’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/misc/spacefm/default.nix:38 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/rdr27ybzf0c521f72k3s58la6sfbf71g-spacefm-1.0.5/bin
patching script interpreter paths in /nix/store/rdr27ybzf0c521f72k3s58la6sfbf71g-spacefm-1.0.5
/nix/store/rdr27ybzf0c521f72k3s58la6sfbf71g-spacefm-1.0.5/bin/spacefm-installer: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/rdr27ybzf0c521f72k3s58la6sfbf71g-spacefm-1.0.5...
Wrapping program /nix/store/rdr27ybzf0c521f72k3s58la6sfbf71g-spacefm-1.0.5/bin/spacefm-installer
Wrapping program /nix/store/rdr27ybzf0c521f72k3s58la6sfbf71g-spacefm-1.0.5/bin/spacefm
Wrapping program /nix/store/rdr27ybzf0c521f72k3s58la6sfbf71g-spacefm-1.0.5/bin/spacefm-auth
/nix/store/rdr27ybzf0c521f72k3s58la6sfbf71g-spacefm-1.0.5
/nix/store/17iam1i41fjxrjyhgqp6jgwss0kmbv0z-udisks-2.1.6
/nix/store/9qmbdp4c57fjdn7clbqs8cypr2jfzw5i-udisks-glue-1.3.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/8jq3l052xb6nhyqls96ya7w26b6yka8r-spacefm-1.0.5/bin 
patching script interpreter paths in /nix/store/8jq3l052xb6nhyqls96ya7w26b6yka8r-spacefm-1.0.5
/nix/store/8jq3l052xb6nhyqls96ya7w26b6yka8r-spacefm-1.0.5/bin/spacefm-installer: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-spacefm-1.0.5.drv-0 in /nix/store/8jq3l052xb6nhyqls96ya7w26b6yka8r-spacefm-1.0.5...
Wrapping program /nix/store/8jq3l052xb6nhyqls96ya7w26b6yka8r-spacefm-1.0.5/bin/spacefm-installer
Wrapping program /nix/store/8jq3l052xb6nhyqls96ya7w26b6yka8r-spacefm-1.0.5/bin/spacefm-auth
Wrapping program /nix/store/8jq3l052xb6nhyqls96ya7w26b6yka8r-spacefm-1.0.5/bin/spacefm
/nix/store/8jq3l052xb6nhyqls96ya7w26b6yka8r-spacefm-1.0.5
/nix/store/c6n87zp110q7cb0rx5cjdj0zl2s24y6l-udisks-2.1.6
/nix/store/26vnh3cjbj2icchfpsqi9wqgwcp35yb0-udisks-glue-1.3.5

@jtojnar
spaceFM: use udisks2
186a5c5
@jtojnar
udisks_glue: use udisks1 alias instead of udisks
c530630 
This will allow us to re-point udisks to udisks2.

Apparently, the package still does not support udisks2:

fernandotcl/udisks-glue#8
@jtojnar
udisks: point to udisks2
0a288a2
@jtojnar jtojnar closed this Feb 28, 2018
@jtojnar jtojnar deleted the udisks2 branch February 28, 2018 15:17
@jtojnar jtojnar restored the udisks2 branch February 28, 2018 15:18
@jtojnar jtojnar deleted the udisks2 branch February 28, 2018 15:18
@jtojnar jtojnar restored the udisks2 branch February 28, 2018 15:18
@jtojnar jtojnar merged commit 0a288a2 into NixOS:master Feb 28, 2018
@jtojnar jtojnar deleted the udisks2 branch February 28, 2018 15:19
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘spacefm-1.0.5’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/misc/spacefm/default.nix:38 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/qj378rp20hgdpnpagmz241zdyszl70b3-spacefm-1.0.5/bin 
patching script interpreter paths in /nix/store/qj378rp20hgdpnpagmz241zdyszl70b3-spacefm-1.0.5
/nix/store/qj378rp20hgdpnpagmz241zdyszl70b3-spacefm-1.0.5/bin/spacefm-installer: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-spacefm-1.0.5.drv-0 in /nix/store/qj378rp20hgdpnpagmz241zdyszl70b3-spacefm-1.0.5...
Wrapping program /nix/store/qj378rp20hgdpnpagmz241zdyszl70b3-spacefm-1.0.5/bin/spacefm-auth
Wrapping program /nix/store/qj378rp20hgdpnpagmz241zdyszl70b3-spacefm-1.0.5/bin/spacefm
Wrapping program /nix/store/qj378rp20hgdpnpagmz241zdyszl70b3-spacefm-1.0.5/bin/spacefm-installer
/nix/store/qj378rp20hgdpnpagmz241zdyszl70b3-spacefm-1.0.5
/nix/store/csbq1w52ggwkg1gqk1zkb2d9a7i29h4w-udisks-2.1.6
/nix/store/p2zkhlhhfnxvn66jns9aya2vsyczni67-udisks-glue-1.3.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

these paths will be fetched (1.06 MiB download, 4.56 MiB unpacked):
  /nix/store/9a5ky0z57qyil3z8cyawx6fdh48f0q3j-udisks-glue-1.3.5
  /nix/store/fxgjdjnb9naicbbnrv77x2pmd0zdzjg0-spacefm-1.0.5
  /nix/store/mjk40p3nc6wz4yxd6p24xpfrg5x8fzbx-ffmpegthumbnailer-2.2.0
copying path '/nix/store/9a5ky0z57qyil3z8cyawx6fdh48f0q3j-udisks-glue-1.3.5' from 'https://cache.nixos.org'...
copying path '/nix/store/mjk40p3nc6wz4yxd6p24xpfrg5x8fzbx-ffmpegthumbnailer-2.2.0' from 'https://cache.nixos.org'...
copying path '/nix/store/fxgjdjnb9naicbbnrv77x2pmd0zdzjg0-spacefm-1.0.5' from 'https://cache.nixos.org'...
/nix/store/fxgjdjnb9naicbbnrv77x2pmd0zdzjg0-spacefm-1.0.5
/nix/store/wd2i3wrai1l7v322k13dc1hcxbzjz5kr-udisks-2.1.6
/nix/store/9a5ky0z57qyil3z8cyawx6fdh48f0q3j-udisks-glue-1.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @GrahamcOfBorg @dotlambda