New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prosody module: add dataDir option #35540
Conversation
@@ -247,6 +247,12 @@ in | |||
description = "Additional prosody configuration"; | |||
}; | |||
|
|||
dataDir = mkOption { | |||
type = types.string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be types.path
.
@@ -318,7 +324,8 @@ in | |||
serviceConfig = { | |||
User = "prosody"; | |||
Type = "forking"; | |||
PIDFile = "/var/lib/prosody/prosody.pid"; | |||
RuntimeDirectory = [ "prosody" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaken, this will create a directory /run/prosody
, but you're using /var/run/prosody
. See https://www.freedesktop.org/software/systemd/man/systemd.exec.html.
And please add a comment what the option does so others don't have to look it up.
@dotlambda Done, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I haven't tested it though.
Motivation for this change
Allow user to use custom path for stateful data directory.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)