Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Object.assign polyfill for IE11 #619

Merged
merged 1 commit into from Mar 7, 2018

Conversation

mwiencek
Copy link
Member

Fixes MBS-9628 and probably many other issues in IE11.

Note: core-js is what babel-polyfill uses, but by using it directly we can include just the parts we need.

Fixes MBS-9628 and probably many other issues in IE11.
@@ -1,3 +1,6 @@
// IE 11 doesn't support Object.assign.
require('core-js/modules/es6.object.assign');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All it does is create a polyfill for Object.assign if it doesn't already exist. If it exists, it falls back to the native one. You can see the source code here: https://github.com/zloirock/core-js/blob/master/modules/es6.object.assign.js

@mwiencek mwiencek merged commit 09b7758 into metabrainz:master Mar 7, 2018
@mwiencek mwiencek deleted the object-assign-polyfill branch March 7, 2018 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants