Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build libseccomp on supported systems #35522

Merged
merged 1 commit into from Feb 25, 2018

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Feb 25, 2018

No description provided.

@Ericson2314
Copy link
Member

Ericson2314 commented Feb 26, 2018

👍 Long term, I hope we can avoid these one-off, yet globally exposed, predicates. But they're fine for now, especially because they're easily triaged since they are all in inspect.nix.

@edolstra
Copy link
Member

What is inspect.nix? That file has no explanation and the name is not very descriptive.

Also, why do attribute names in that file have initial caps? That's not consistent with our usual attribute naming.

@shlevy
Copy link
Member Author

shlevy commented Feb 26, 2018

@Ericson2314 Yeah, I think a lot of this stuff should live near the affected package, not here.

@edolstra
Copy link
Member

Okay, I see there is some nameValuePair ("is" + name) magic. Please don't do that. It makes it impossible to grep for the definition of identifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants