Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: Modify ceph package so that it compiles and runs fine on nixos #35479

Merged
merged 1 commit into from Feb 26, 2018
Merged

ceph: Modify ceph package so that it compiles and runs fine on nixos #35479

merged 1 commit into from Feb 26, 2018

Conversation

lejonet
Copy link
Contributor

@lejonet lejonet commented Feb 24, 2018

With adding a patch that makes 2 absolute paths into 2 relative paths, ensuring the third-party libraries are available
in the python environment used and wrapping the python tools with wrapPrograms does so that the fixed ceph pkg can
compile and run as intended on NixOS.

Motivation for this change

The fixed package for ceph was made to be compiled and run on non-nixos systems, this PR fixes so that the fixed package can compile and run successfully on NixOS too.
The git dependency could also be removed, its not needed unless you want to run tests defined in the source tree or generate release notes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lejonet
ceph: Modify ceph package so that it compiles and runs fine on nixos
987cad8 
With adding a patch that makes 2 absolute paths into 2 relative paths, ensuring the third-party libraries are available
in the python environment used and wrapping the python tools with wrapPrograms does so that the fixed ceph pkg can
compile and run as intended on NixOS.
@Mic92
Copy link
Member

Mic92 commented Feb 25, 2018

@GrahamcOfBorg build ceph

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘lttng-ust-2.10.0’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/tools/misc/lttng-ust/default.nix:32 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/parasgpqbahfvzwv87l1fhxl72xxq37s-zfs-user-0.7.6-lib/libexec/zfs/zpool.d/encdev: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
/nix/store/parasgpqbahfvzwv87l1fhxl72xxq37s-zfs-user-0.7.6-lib/libexec/zfs/zpool.d/enc: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/parasgpqbahfvzwv87l1fhxl72xxq37s-zfs-user-0.7.6-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/k4qv8i2cilbx10fdw4xrly3xpyzjfjxn-zfs-user-0.7.6-dev
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/k4qv8i2cilbx10fdw4xrly3xpyzjfjxn-zfs-user-0.7.6-dev/lib
patching script interpreter paths in /nix/store/k4qv8i2cilbx10fdw4xrly3xpyzjfjxn-zfs-user-0.7.6-dev
checking for references to /build in /nix/store/k4qv8i2cilbx10fdw4xrly3xpyzjfjxn-zfs-user-0.7.6-dev...
cannot build derivation '/nix/store/iwhwz8212q22ksisiahfamg6l28ghz4d-ceph-12.2.2.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/iwhwz8212q22ksisiahfamg6l28ghz4d-ceph-12.2.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

[ 30%] Building CXX object src/rgw/CMakeFiles/rgw_a.dir/rgw_auth.cc.o
[ 30%] Building CXX object src/rgw/CMakeFiles/rgw_a.dir/rgw_auth_keystone.cc.o
[ 30%] Building CXX object src/rgw/CMakeFiles/rgw_a.dir/rgw_auth_s3.cc.o
[ 30%] Building CXX object src/rgw/CMakeFiles/rgw_a.dir/rgw_basic_types.cc.o
[ 30%] Building CXX object src/rgw/CMakeFiles/rgw_a.dir/rgw_bucket.cc.o
[ 30%] Building CXX object src/rgw/CMakeFiles/rgw_a.dir/rgw_cache.cc.o
[ 30%] Building CXX object src/rgw/CMakeFiles/rgw_a.dir/rgw_client_io.cc.o
[ 30%] Building CXX object src/rgw/CMakeFiles/rgw_a.dir/rgw_common.cc.o
building of ‘/nix/store/40vy9ms9pii00p7vgxs546pz625c1085-ceph-12.2.2.drv’ timed out after 3600 seconds
error: build of ‘/nix/store/40vy9ms9pii00p7vgxs546pz625c1085-ceph-12.2.2.drv’ failed

@Mic92 Mic92 merged commit 0db6ad2 into NixOS:master Feb 26, 2018
@Mic92
Copy link
Member

Mic92 commented Feb 26, 2018

runs so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lejonet @Mic92 @GrahamcOfBorg