-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pkgs.biber on Darwin #35477
Fix pkgs.biber on Darwin #35477
Conversation
Tested this a little on Darwin. Out of the current perlPackages in all-packages:
Working using this PR:
Just wanted to bump this because of #47302 |
I am having this issue with |
This needs to be rebased to staging |
I rebased this PR but only enabled the fix for |
I tested the change on MacOS and Ubuntu. I think it should be merge-able now. |
Making a copy of a builder for just a single package is not an optimal solution from the maintenance perspective. Ideally, the workaround would just override the phases or pre/post hooks of the |
@veprbl @volth I have 2 solutions for this issue in 2 separate PRs. (FYI: original problem is described here: #35353) Solution 1: #35477 (this PR)
Solution 2: #62156
I believe @veprbl prefers solution 2. I don't mind either way. I'm just keeping solution 1 around for now since it's more practical for people needing If either of these solutions gets merged, there remains an open question of whether the shebang hack needs to be removed completely and if so, how to do it safely. Due to limited time I cannot commit to this larger project. However, even if it remains unsolved, merging one of these solutions will allow simple fixes for |
@boronine
Single time rebuild is not an issue, especially if it is limited to perl related stuff. This can be tested by building a few packages and comparing the build outputs to the original. This will be also built on Hydra and if there is a major breakage that will be visible. So there is no downside here actually.
Even if solution 1 would be merged, I'm pretty sure someone soon would pick up the work on deduplication of those builders to get it into the shape of solution 2 for the reason described above. |
Fix for #35353
pkgs.biber
packagedoUseWrapper
in the perl-modules builderThings done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)