Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdesktop: add native notifications support #35478

Merged
merged 1 commit into from Feb 25, 2018
Merged

tdesktop: add native notifications support #35478

merged 1 commit into from Feb 25, 2018

Conversation

svsdep
Copy link
Contributor

@svsdep svsdep commented Feb 24, 2018 •
edited

Motivation for this change

By patching paths to required libs in sources, application
is able to load them and provide an option to use native notifications.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@abbradar
Copy link
Member

Instead of using LD_LIBRARY_PATH can't we patch source code to include full paths to the libraries? Usually that's straightforward -- grep by the library name and use substituteInPlace.

@svsdep
tdesktop: add native notifications support
8ee2d38 
By patching paths to required libs in sources, application
is able to load them and provide an option to use native notifications.
@svsdep
Copy link
Contributor Author

svsdep commented Feb 25, 2018

@abbradar thanks for advice! Reworked using substituteInPlace. Ready for review.

@abbradar
Copy link
Member

Tested, works for me. Thanks!

@abbradar abbradar merged commit 1865ce4 into NixOS:master Feb 25, 2018
@svsdep svsdep deleted the tdesktop-notifications branch February 26, 2018 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@svsdep @abbradar @GrahamcOfBorg