ndppd module: init #35533
Merged
ndppd module: init #35533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Feb 25, 2018
| enable = mkEnableOption "daemon that proxies NDP (Neighbor Discovery Protocol) messages between interfaces"; | ||
| interface = mkOption { | ||
| type = types.string; | ||
| default = "eth1"; |
There was a problem hiding this comment.
Shouldn't be this better an example?
Mic92
reviewed
Feb 25, 2018
| }; | ||
| network = mkOption { | ||
| type = types.string; | ||
| default = "1111::/113"; |
There was a problem hiding this comment.
You can use 2001:DB8::/32 here, which is reserved for documentation and never used in the internet.
|
@Mic92 Done, thanks! |
|
@matthewbauer Merge please? |
|
@matthewbauer Thank you! |
ghost
deleted the
globin
pushed a commit
to mayflower/nixpkgs
that referenced
this pull request
May 24, 2018
(cherry picked from commit 9f1da66)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add module for NDP Proxy daemon.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)