Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: KSP-CKAN/CKAN
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2855e4810d2f
Choose a base ref
...
head repository: KSP-CKAN/CKAN
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ca2b052fc634
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Feb 25, 2018

  1. Don't crash if download_hash isn't set

    @HebaruSan
    HebaruSan committed Feb 25, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    424b0c2 View commit details

  2. Merge #2313 Don't crash if download_hash isn't set

    @politas
    politas committed Feb 25, 2018
    Copy the full SHA
    ca2b052 View commit details
Showing with 3 additions and 1 deletion.
  1. +1 −0 CHANGELOG.md
  2. +2 −1 Core/Types/CkanModule.cs
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -10,6 +10,7 @@ All notable changes to this project will be documented in this file.
- [GUI] Handle mod not found in versions tab (#2303 by: HebaruSan; reviewed: politas)
- [GUI] Better resizing for Select KSP Install window (#2306 by: HebaruSan; reviewed: politas)
- [GUI] Fix GUI sort by size (#2311 by: HebaruSan; reviewed: politas)
- [Core] Don't crash if download_hash isn't set (#2313 by: HebaruSan; reviewed: politas)

## v1.24.0 (Bruce)

3 changes: 2 additions & 1 deletion Core/Types/CkanModule.cs
View file
Original file line number Diff line number Diff line change
@@ -633,7 +633,8 @@ public Uri InternetArchiveDownload
get
{
string verStr = version.ToString().Replace(':', '-');
return license.All(l => l.Redistributable)
// Some alternate registry repositories don't set download_hash
return (download_hash?.sha1 != null && license.All(l => l.Redistributable))
? new Uri(
$"https://archive.org/download/{identifier}-{verStr}/{download_hash.sha1.Substring(0, 8)}-{identifier}-{verStr}.zip")
: null;