Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnujump: init at 1.0.8 #35494

Merged
merged 1 commit into from Mar 4, 2018
Merged

gnujump: init at 1.0.8 #35494

merged 1 commit into from Mar 4, 2018

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Feb 24, 2018

Motivation for this change

A classic.

Can someone test if it works on darwin too? The website only mentions GNU/Linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Mar 1, 2018

@GrahamcOfBorg build gnujump

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘gnujump-1.0.8’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/games/gnujump/default.nix:14 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

make[2]: Leaving directory '/tmp/nix-build-gnujump-1.0.8.drv-0/gnujump-1.0.8'
make[1]: Leaving directory '/tmp/nix-build-gnujump-1.0.8.drv-0/gnujump-1.0.8'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8214g2j3a227js3iidk6xjvjbgi4n3f8-gnujump-1.0.8
shrinking /nix/store/8214g2j3a227js3iidk6xjvjbgi4n3f8-gnujump-1.0.8/bin/gnujump
gzipping man pages under /nix/store/8214g2j3a227js3iidk6xjvjbgi4n3f8-gnujump-1.0.8/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/8214g2j3a227js3iidk6xjvjbgi4n3f8-gnujump-1.0.8/bin 
patching script interpreter paths in /nix/store/8214g2j3a227js3iidk6xjvjbgi4n3f8-gnujump-1.0.8
checking for references to /tmp/nix-build-gnujump-1.0.8.drv-0 in /nix/store/8214g2j3a227js3iidk6xjvjbgi4n3f8-gnujump-1.0.8...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

make[2]: Leaving directory '/build/gnujump-1.0.8'
make[1]: Leaving directory '/build/gnujump-1.0.8'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ig9gm445fn718csn0bvf15w3k22ihplb-gnujump-1.0.8
shrinking /nix/store/ig9gm445fn718csn0bvf15w3k22ihplb-gnujump-1.0.8/bin/gnujump
gzipping man pages under /nix/store/ig9gm445fn718csn0bvf15w3k22ihplb-gnujump-1.0.8/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ig9gm445fn718csn0bvf15w3k22ihplb-gnujump-1.0.8/bin
patching script interpreter paths in /nix/store/ig9gm445fn718csn0bvf15w3k22ihplb-gnujump-1.0.8
checking for references to /build in /nix/store/ig9gm445fn718csn0bvf15w3k22ihplb-gnujump-1.0.8...

@dtzWill
Copy link
Member

dtzWill commented Mar 1, 2018

Please switch the source URL to use the mirror://gnu .

Also if you want to see if it at least builds on Darwin, include it in platforms and helpful Borg bot will let us know how that works out :).

@fgaz
Copy link
Member Author

fgaz commented Mar 2, 2018

@GrahamcOfBorg build gnujump

@fgaz
Copy link
Member Author

fgaz commented Mar 2, 2018

Right, I don't have the bits to do that. @dtzWill could you trigger it?

@dtzWill
Copy link
Member

dtzWill commented Mar 2, 2018

I thought just pushing the commit would be enough, whoops. Sure:

@GrahamcOfBorg build gnujump

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

make[2]: Leaving directory '/tmp/nix-build-gnujump-1.0.8.drv-0/gnujump-1.0.8'
make[1]: Leaving directory '/tmp/nix-build-gnujump-1.0.8.drv-0/gnujump-1.0.8'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8214g2j3a227js3iidk6xjvjbgi4n3f8-gnujump-1.0.8
shrinking /nix/store/8214g2j3a227js3iidk6xjvjbgi4n3f8-gnujump-1.0.8/bin/gnujump
gzipping man pages under /nix/store/8214g2j3a227js3iidk6xjvjbgi4n3f8-gnujump-1.0.8/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/8214g2j3a227js3iidk6xjvjbgi4n3f8-gnujump-1.0.8/bin 
patching script interpreter paths in /nix/store/8214g2j3a227js3iidk6xjvjbgi4n3f8-gnujump-1.0.8
checking for references to /tmp/nix-build-gnujump-1.0.8.drv-0 in /nix/store/8214g2j3a227js3iidk6xjvjbgi4n3f8-gnujump-1.0.8...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/build/gnujump-1.0.8'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ig9gm445fn718csn0bvf15w3k22ihplb-gnujump-1.0.8
shrinking /nix/store/ig9gm445fn718csn0bvf15w3k22ihplb-gnujump-1.0.8/bin/gnujump
gzipping man pages under /nix/store/ig9gm445fn718csn0bvf15w3k22ihplb-gnujump-1.0.8/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ig9gm445fn718csn0bvf15w3k22ihplb-gnujump-1.0.8/bin
patching script interpreter paths in /nix/store/ig9gm445fn718csn0bvf15w3k22ihplb-gnujump-1.0.8
checking for references to /build in /nix/store/ig9gm445fn718csn0bvf15w3k22ihplb-gnujump-1.0.8...
/nix/store/ig9gm445fn718csn0bvf15w3k22ihplb-gnujump-1.0.8

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

checking for egrep... /nix/store/5q6mgrw5a1qh0i548y93gs8ibsnhabbd-gnugrep-3.1/bin/grep -E
checking for CFPreferencesCopyAppValue... yes
checking for CFLocaleCopyCurrent... yes
checking for GNU gettext in libc... no
checking for iconv... no, consider installing GNU libiconv
checking for GNU gettext in libintl... no
checking whether to use NLS... no
checking for sdl-config... /nix/store/yjrwwp6ixic2w6m9zkdhjp1kb6dx7b52-SDL-1.2.15-dev/bin/sdl-config
building of '/nix/store/b2kzi54x9fhyqxisv9fc1ndz4b23rd7a-gnujump-1.0.8.drv' timed out after 1800 seconds
error: build of '/nix/store/b2kzi54x9fhyqxisv9fc1ndz4b23rd7a-gnujump-1.0.8.drv' failed

@dtzWill
Copy link
Member

dtzWill commented Mar 2, 2018

lmao the sounds 👍

@dtzWill
Copy link
Member

dtzWill commented Mar 2, 2018

Asked folks on #nix-darwin and it seems we should disable Darwin support for now. Thanks for giving it a try. Here's what they said:

we've had issues SDL-config on hydra before
if it's back we should fix that or disable the build otherwise it blocks one of the macs for ~10h with every rebuild

@fgaz
Copy link
Member Author

fgaz commented Mar 4, 2018

I don't know if the the push triggered a notification, but in case it didn't: I removed darwin from platforms

@Mic92 Mic92 merged commit eca1f71 into NixOS:master Mar 4, 2018
@fgaz fgaz deleted the gnujump branch March 5, 2018 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fgaz @dtzWill @GrahamcOfBorg @Mic92