Add BLOG_EMAIL to global context to make it available for templates #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
requested changes
Feb 25, 2018
nikola/nikola.py
Outdated
| @@ -451,6 +451,7 @@ def __init__(self, **config): | |||
| 'AUTHORLIST_MINIMUM_POSTS': 1, | |||
| 'BLOG_AUTHOR': 'Default Author', | |||
| 'BLOG_TITLE': 'Default Title', | |||
| 'BLOG_EMAIL': 'Default EMail', | |||
There was a problem hiding this comment.
Make it an empty string, please.
nikola/conf.py.in
Outdated
| @@ -25,7 +25,7 @@ SITE_URL = ${SITE_URL} | |||
| # This is the URL where Nikola's output will be deployed. | |||
| # If not set, defaults to SITE_URL | |||
| # BASE_URL = ${SITE_URL} | |||
| BLOG_EMAIL = ${BLOG_EMAIL} | |||
| BLOG_EMAIL = ${BLOG_EMAIL} # (translatable) | |||
There was a problem hiding this comment.
I don’t think BLOG_EMAIL needs to be translatable. You can just make it a regular string (as blog_url is).
Kwpolska
reviewed
Feb 25, 2018
nikola/nikola.py
Outdated
| @@ -656,6 +657,7 @@ def __init__(self, **config): | |||
|
|
|||
| self.TRANSLATABLE_SETTINGS = ('BLOG_AUTHOR', | |||
| 'BLOG_TITLE', | |||
| 'BLOG_EMAIL', | |||
There was a problem hiding this comment.
This one and _GLOBAL_CONTEXT_TRANSLATABLE (line 696) need to be removed as well.
There was a problem hiding this comment.
oh, missed this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Add BLOG_EMAIL to global context to make it available for templates. Fix Issue #2968